New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Step 7: Simulation Clang tidy code-checks-all #20532
Conversation
…ag is set: -Wunused-variable
please test |
The code-checks are being triggered in jenkins. |
+code-checks |
hold |
Pull request has been put on hold by @ianna |
The tests are being triggered in jenkins. |
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: SimCalorimetry/CaloSimAlgos @civanch, @mdhildreth, @cmsbuild, @rekovic, @kpedro88, @mulhearn can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
unhold |
Note, #20530 relval 10042 test has failed previously, but it passed fine here. |
hi @civanch - please object to merging this PR in the next hours, It looks straightforward. |
+1 |
Step 7. SimCalorimetry
It will be rebased if needed after they are subsequently merged.
@civanch - FYI