Add displacedJet skim / add relval steps / add RAW+AOD event content #21260

kfjack · 2017-11-10T14:44:39Z

Integrate all of the modifications from PR #20948:

Add displacedJet skim
Add the corresponding relval steps
Add RAW+AOD event content

cmsbuild · 2017-11-10T14:45:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-11-10T14:47:31Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21260/1929

cmsbuild · 2017-11-10T14:48:29Z

A new Pull Request was created by @kfjack (Kai-Feng Chen) for master.

It involves the following packages:

Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/Skimming

@prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @ebrondol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

fabozzi · 2017-11-10T17:42:02Z

please test workflow 136.804

cmsbuild · 2017-11-10T17:42:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24359/console Started: 2017/11/10 19:24

cmsbuild · 2017-11-10T21:17:22Z

+1
Tested at: 11845f1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/24359/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
62cb420
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/24359/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/24359/git-merge-result

cmsbuild · 2017-11-10T21:17:25Z

Comparison job queued.

cmsbuild · 2017-11-10T23:04:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/24359/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2832699
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2832520
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.14000000004 KiB( 23 files compared)
Checked 111 log files, 8 edm output root files, 27 DQM output files

fabozzi · 2017-11-12T15:12:53Z

+1

cmsbuild · 2018-01-12T15:41:24Z

-1

Tested at: 11845f1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/25410/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

cmsbuild · 2018-01-12T15:41:26Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

smuzaffar · 2018-01-15T09:13:39Z

@fabiocos , although all workflow in the above tests ran fine but there was this error in the runTheMatrix output https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/25410/runTheMatrix-results/matrixTests.log

processing relval_standard
ERROR in Matrix
overwritting 136.804 not allowed

as cms-bot just grep for 'ERROR' in this file that is why it assumed that something failed.

fabiocos · 2018-01-15T09:25:45Z

please test

cmsbuild · 2018-01-15T09:26:05Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25438/console Started: 2018/01/15 10:27

smuzaffar · 2018-01-15T10:28:13Z

Configuration/PyReleaseValidation/python/relval_standard.py

@@ -251,6 +251,7 @@
 workflows[136.801] = ['',['RunZeroBias2017C','HLTDR2_2017','RECODR2_2017reHLT_Prompt','HARVEST2017']]
 workflows[136.802] = ['',['RunMuOnia2017C','HLTDR2_2017','RECODR2_2017reHLT_skimMuOnia_Prompt','HARVEST2017']]
 workflows[136.803] = ['',['RunNoBPTX2017C','HLTDR2_2017','RECODR2_2017reHLTAlCaTkCosmics_Prompt','HARVEST2017']]
+workflows[136.804] = ['',['RunDisplacedJet2017C','HLTDR2_2017','RECODR2_2017reHLT_skimDisplacedJet_Prompt','HARVEST2017']]


@fabiocos , I think runTheMatrix complain about this override?

fabozzi · 2018-01-15T10:33:06Z

I think this PR needs a rebase, since new relvals have been introduced since when this was originally deployed.

cmsbuild · 2018-01-15T11:33:10Z

-1

Tested at: 11845f1

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21260/25438/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

cmsbuild · 2018-01-15T11:33:12Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

kfjack · 2018-01-15T11:34:39Z

So I guess I should restart a new PR with new CMSSW? Will do that in a moment.

fabiocos · 2018-01-15T12:37:35Z

@kfjack Either you modify this PR or open a new one, and we close this one...

kfjack · 2018-01-15T15:35:53Z

Ok, I just tried a quick rebase but the local test also failed. Will restart from a clean release again (will be a new PR in this case).

kfjack · 2018-01-16T09:03:46Z

Hi all, I managed to restart a new PR #21857 with a clean new IB. I will close this PR in a moment.

Add displacedJet skim / add relval steps / add RAW+miniAOD event content

11845f1

cmsbuild added this to the CMSSW_10_0_X milestone Nov 10, 2017

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pdmv-pending pending-signatures tests-pending upgrade-pending labels Nov 10, 2017

kfjack mentioned this pull request Nov 10, 2017

Add relval steps for DisplacedJet PD + RAW-AOD event content + EXODisplacedJet skim #20948

Closed

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 10, 2017

cmsbuild added tests-started and removed tests-pending labels Nov 10, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2017

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2017

cmsbuild added pdmv-approved and removed pdmv-pending labels Nov 12, 2017

cmsbuild added the tests-started label Jan 12, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 12, 2018

cmsbuild added comparison-pending tests-pending tests-started and removed comparison-notrun tests-rejected tests-pending labels Jan 15, 2018

smuzaffar reviewed Jan 15, 2018

View reviewed changes

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 15, 2018

kfjack mentioned this pull request Jan 16, 2018

Add displacedJet skim / add relval steps / add RAW+miniAOD event content (new IB) #21857

Merged

kfjack closed this Jan 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add displacedJet skim / add relval steps / add RAW+AOD event content #21260

Add displacedJet skim / add relval steps / add RAW+AOD event content #21260

kfjack commented Nov 10, 2017 •

edited

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

fabozzi commented Nov 10, 2017

cmsbuild commented Nov 10, 2017 •

edited

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

fabozzi commented Nov 12, 2017

cmsbuild commented Jan 12, 2018

cmsbuild commented Jan 12, 2018

smuzaffar commented Jan 15, 2018

fabiocos commented Jan 15, 2018

cmsbuild commented Jan 15, 2018 •

edited

smuzaffar Jan 15, 2018

fabozzi commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

kfjack commented Jan 15, 2018

fabiocos commented Jan 15, 2018

kfjack commented Jan 15, 2018

kfjack commented Jan 16, 2018

Add displacedJet skim / add relval steps / add RAW+AOD event content #21260

Add displacedJet skim / add relval steps / add RAW+AOD event content #21260

Conversation

kfjack commented Nov 10, 2017 • edited

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

fabozzi commented Nov 10, 2017

cmsbuild commented Nov 10, 2017 • edited

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

cmsbuild commented Nov 10, 2017

fabozzi commented Nov 12, 2017

cmsbuild commented Jan 12, 2018

cmsbuild commented Jan 12, 2018

smuzaffar commented Jan 15, 2018

fabiocos commented Jan 15, 2018

cmsbuild commented Jan 15, 2018 • edited

smuzaffar Jan 15, 2018

Choose a reason for hiding this comment

fabozzi commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

cmsbuild commented Jan 15, 2018

kfjack commented Jan 15, 2018

fabiocos commented Jan 15, 2018

kfjack commented Jan 15, 2018

kfjack commented Jan 16, 2018

kfjack commented Nov 10, 2017 •

edited

cmsbuild commented Nov 10, 2017 •

edited

cmsbuild commented Jan 15, 2018 •

edited