Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add displacedJet skim / add relval steps / add RAW+miniAOD event content (new IB) #21857

Merged
merged 1 commit into from Jan 26, 2018

Conversation

kfjack
Copy link
Contributor

@kfjack kfjack commented Jan 16, 2018

Integrate all of the modifications from PR #21260 with new IB

Add displacedJet skim
Add the corresponding relval steps
Add RAW+AOD event content

Note: now the new workflow(s) to be tested are 136.840, 136.841, 136.842, 136.843.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @kfjack (Kai-Feng Chen) for master.

It involves the following packages:

Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/Skimming

@prebello, @kpedro88, @fabozzi, @cmsbuild, @franzoni, @GurpreetSinghChahal, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@ghellwig, @felicepantaleo, @ebrondol, @Martin-Grunewald, @makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabozzi
Copy link
Contributor

fabozzi commented Jan 16, 2018

please test workflow 136.840,136.841,136.842,136.843

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25461/console Started: 2018/01/16 10:11
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25466/console Started: 2018/01/16 14:42

@cmsbuild
Copy link
Contributor

-1

Tested at: b0a8a79

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21857/25466/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
136.841 step2

runTheMatrix-results/136.841_RunDisplacedJet2017D+RunDisplacedJet2017D+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017/step2_RunDisplacedJet2017D+RunDisplacedJet2017D+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017.log

136.842 step2
runTheMatrix-results/136.842_RunDisplacedJet2017E+RunDisplacedJet2017E+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017/step2_RunDisplacedJet2017E+RunDisplacedJet2017E+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017.log

@cmsbuild
Copy link
Contributor

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@kfjack
Copy link
Contributor Author

kfjack commented Jan 18, 2018

Could we test the workflow again? Previous tests were rejected simply due to I/O error.

@fabozzi
Copy link
Contributor

fabozzi commented Jan 18, 2018

please test workflow 136.840,136.841,136.842,136.843

@fabozzi
Copy link
Contributor

fabozzi commented Jan 18, 2018

(let's test with the relvals for which the input RAW seems to be available)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21857/25511/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21857/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21857/136.843_RunDisplacedJet2017F+RunDisplacedJet2017F+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21857/136.84_RunDisplacedJet2017C+RunDisplacedJet2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDisplacedJet_Prompt+HARVEST2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467429
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.34000000013 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Jan 18, 2018

@jingyuluo
Can you have a look at the skim output of relval 136.840 and 136.843 in this test?
Thank you!

@jingyuluo
Copy link
Contributor

Dear @fabozzi ,

Sorry I missed the message... The event content of the skim output looks good for me!

Many thanks!
Jingyu

@fabozzi
Copy link
Contributor

fabozzi commented Jan 22, 2018

+1

@kpedro88
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8f94a93 into cms-sw:master Jan 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants