Broken Geometry Paths

[bsunanda]

No description provided.

[cmsbuild]

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Broken Geometry Paths

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @kknb1056 you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ianna]

+1

[cmsbuild]

Pull request #2129 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

[ianna]

@ktf - could you, please, merge it before next IB? Thanks.

[ktf]

Bypassing signatures as requested. Complain with @ianna if not ok… ;)

[kknb1056]

@ianna @bsunanda
The change to DataFormats/HcalDetId/src/HcalDetId.cc breaks the Hcal SimHit validation. Tests 3400, 4502 and 15001 fail with
----- Begin Fatal Exception 23-Jan-2014 18:51:28 CET-----------------------
An exception of category 'MonitorElement' occurred while
[0] Processing run: 1 lumi: 1 event: 1
[1] Running path 'validation_step'
[2] Calling event method for module SimHitsValidationHcal/'AllSimHitsValidation'
Exception Message:
Method 'void MonitorElement::Fill(double, double, double)' cannot be invoked on monitor element 'Energy_HB'
----- End Fatal Exception -------------------------------------------------

This is because the array subscript is out of range in Validation/HcalHits/src/SimHitsValidationHcal.cc around line 244 (where meHcalEnergyl250_ is accessed and Fill() called). This array subscript is set around lines 158-183 from HcalDetId::depth(). This could be as simple as increasing nType in SimHitsValidationHcal.h (i.e. increasing the size of the arrays). I don't understand the code where the array index is decide or your changes though. Could you look into this and update SimHitsValidationHcal.cc/.h?

[ianna]

@kknb1056 - there will be more code coming in from Sunanda later today, we'll make sure this is also fixed.

[ianna]

@kknb1056 - how can I reproduce it? When I run

CMSSW_6_2_X_SLHC_2014-01-24-0200/relval $ runTheMatrix.py -l 3400
processing  relval_standard
request for INPUT for  None
ERROR reading file: relval_standard 'SingleMuPt1_UP15'
Traceback (most recent call last):
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-01-24-0200/bin/slc5_amd64_gcc472/runTheMatrix.py", line 234, in <module>
    ret = runSelected(opt)
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-01-24-0200/bin/slc5_amd64_gcc472/runTheMatrix.py", line 23, in runSelected
    mrd.prepare(opt.useInput, opt.refRel, opt.fromScratch)
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-01-24-0200/python/Configuration/PyReleaseValidation/MatrixReader.py", line 433, in prepare
    self.readMatrix(matrixFile, useInput, refRel, fromScratch)
  File "/afs/cern.ch/cms/sw/ReleaseCandidates/vol0/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-01-24-0200/python/Configuration/PyReleaseValidation/MatrixReader.py", line 225, in readMatrix
    cfg, input, opts = self.makeCmd(self.relvalModule.steps[stepName])
KeyError: 'SingleMuPt1_UP15'

[mark-grimes]

@ianna use "-w upgrade"

runTheMatrix.py -w upgrade -l 3400

[ktf]

BTW, can someone define a set of tests to run in SLHC IBs? obviously the standard matrix is of no particular use, IIUC.

[mark-grimes]

I’m currently using
runTheMatrix.py -j 6 -w upgrade -l 3300,3400,4100,4400,40001,50002,60002,60001,4502,4500,5001,15001,50001
which I inherited from David. This doesn’t include any tests for the GEMs though, which I need to look at including sometime next week. Might be missing some others as well which I need to check up on.