Remove duplicated code used to decode FED header and trailer #21690

mommsen · 2017-12-12T17:25:42Z

For historical reasons, there are two implementations to decode the FED header and trailer. This pull requests removes this duplication and tries to unify how informations found in the FED header and trailer is accessed.

This pull request addressed issues #14353 and #21312. It is also a required for the pull request #21436.

…ion.

cmsbuild · 2017-12-12T17:26:14Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-12-12T17:28:52Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21690/2552

mommsen · 2017-12-12T17:29:06Z

please test

cmsbuild · 2017-12-12T17:29:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25058/console Started: 2017/12/12 18:29

cmsbuild · 2017-12-12T17:29:22Z

A new Pull Request was created by @mommsen (Remi Mommsen) for master.

It involves the following packages:

DQM/DTMonitorModule
DQM/EcalPreshowerMonitorModule
DQM/L1TMonitor
DataFormats/DTDigi
DataFormats/FEDRawData
DataFormats/TCDS
EventFilter/CTPPSRawToDigi
EventFilter/DTRawToDigi
EventFilter/ESDigiToRaw
EventFilter/ESRawToDigi
EventFilter/FEDInterface
EventFilter/L1GlobalTriggerRawToDigi
EventFilter/L1TRawToDigi
EventFilter/RPCRawToDigi
EventFilter/RctRawToDigi
EventFilter/SiPixelRawToDigi
EventFilter/SiStripRawToDigi
EventFilter/Utilities
IORawData/DTCommissioning

@perrotta, @cmsbuild, @civanch, @vazzolini, @ghellwig, @kmaeshima, @arunhep, @emeschi, @mdhildreth, @dmitrijus, @nsmith-, @rekovic, @franzoni, @jfernan2, @cerminar, @thomreis, @slava77, @mommsen, @vanbesien, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @kreczko, @makortel, @forthommel, @tocheng, @argiro, @Martin-Grunewald, @dkotlins, @rovere, @thomreis, @ebrondol, @VinInn, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-12-12T18:45:21Z

-1

Tested at: 1515c93

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e2188ba
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25058/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25058/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25058/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

8.0 step2

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step2_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

7.3 step2

runTheMatrix-results/7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17/step2_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step2

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step2_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1306.0 step2

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step2_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step2

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step2_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step2

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step2_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1330.0 step2

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step2_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

25202.0 step2

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step2_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10042.0 step2

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step2

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10224.0 step2

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

10824.0 step2

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

11624.0 step2

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019/step2_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019.log

20034.0 step2

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step2

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

21234.0 step2

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step2_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:28:35 2017-date Tue Dec 12 19:27:42 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:28:35 2017-date Tue Dec 12 19:27:42 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:29:11 2017-date Tue Dec 12 19:27:44 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:29:11 2017-date Tue Dec 12 19:27:44 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v31.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:36:01 2017-date Tue Dec 12 19:27:47 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v31,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v31 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v31_MC.root --fileout file:RelVal_Raw_2e34v31_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:36:01 2017-date Tue Dec 12 19:27:47 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:29:26 2017-date Tue Dec 12 19:27:52 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=HeavyIons -n 10 --conditions auto:run2_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016,Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:29:26 2017-date Tue Dec 12 19:27:52 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:32:01 2017-date Tue Dec 12 19:27:56 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:32:01 2017-date Tue Dec 12 19:27:56 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:36:06 2017-date Tue Dec 12 19:27:58 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:36:06 2017-date Tue Dec 12 19:27:58 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:31:11 2017-date Tue Dec 12 19:28:45 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:31:11 2017-date Tue Dec 12 19:28:45 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:35:40 2017-date Tue Dec 12 19:29:18 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --mc --scenario=HeavyIons -n 10 --conditions auto:run2_mc_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_HI --processName=HLTRECO --filein file:RelVal_Raw_HIon_MC.root --fileout file:RelVal_Raw_HIon_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:35:40 2017-date Tue Dec 12 19:29:18 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v40.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:37:50 2017-date Tue Dec 12 19:29:29 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v40,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v40 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v40_MC.root --fileout file:RelVal_Raw_2e34v40_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:37:50 2017-date Tue Dec 12 19:29:29 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v31.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:36:42 2017-date Tue Dec 12 19:31:12 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v31,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v31 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v31_DATA.root --fileout file:RelVal_Raw_2e34v31_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:36:42 2017-date Tue Dec 12 19:31:12 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:38:26 2017-date Tue Dec 12 19:32:05 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:38:26 2017-date Tue Dec 12 19:32:05 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:40:46 2017-date Tue Dec 12 19:34:10 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_MC.root --fileout file:RelVal_Raw_2e34v22_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:40:46 2017-date Tue Dec 12 19:34:10 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v22.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:40:19 2017-date Tue Dec 12 19:35:44 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_DATA.root --fileout file:RelVal_Raw_2e34v22_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:40:19 2017-date Tue Dec 12 19:35:44 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:39:31 2017-date Tue Dec 12 19:36:06 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:39:31 2017-date Tue Dec 12 19:36:06 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:42:31 2017-date Tue Dec 12 19:36:08 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:42:31 2017-date Tue Dec 12 19:36:08 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:40:53 2017-date Tue Dec 12 19:36:43 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:40:53 2017-date Tue Dec 12 19:36:43 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:40:05 2017-date Tue Dec 12 19:37:58 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:40:05 2017-date Tue Dec 12 19:37:58 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_2e34v40.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:42:33 2017-date Tue Dec 12 19:38:32 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v40,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v40 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v40_DATA.root --fileout file:RelVal_Raw_2e34v40_DATA_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:42:33 2017-date Tue Dec 12 19:38:32 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:43:18 2017-date Tue Dec 12 19:39:24 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:43:18 2017-date Tue Dec 12 19:39:24 2017 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/nweek-02502/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_0_X_2017-12-12-1100/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Tue Dec 12 19:43:18 2017-date Tue Dec 12 19:39:39 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Tue Dec 12 19:43:18 2017-date Tue Dec 12 19:39:39 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e2188ba
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25058/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25058/git-merge-result

cmsbuild · 2017-12-12T18:45:23Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2017-12-13T13:06:00Z

Pull request #21690 was updated. @perrotta, @cmsbuild, @civanch, @vazzolini, @ghellwig, @kmaeshima, @arunhep, @emeschi, @mdhildreth, @dmitrijus, @nsmith-, @rekovic, @franzoni, @jfernan2, @cerminar, @thomreis, @slava77, @mommsen, @vanbesien, @lpernie can you please check and sign again.

cmsbuild · 2017-12-13T16:21:53Z

+1
Tested at: 26cf0d9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25074/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
25dd061
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25074/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25074/git-merge-result

cmsbuild · 2017-12-13T16:21:55Z

Comparison job queued.

cmsbuild · 2017-12-13T18:24:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21690/25074/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21690/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 16 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2835291
DQMHistoTests: Total failures: 1933
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2833180
DQMHistoTests: Total skipped: 178
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.929999999993 KiB( 23 files compared)
Checked 113 log files, 9 edm output root files, 27 DQM output files

slava77 · 2017-12-14T19:08:21Z

+1

for #21690 26cf0d9

somewhat technical cleanup: reco packages are affected via changes in dependencies or a small interface change (e.g. fedTrailer.lenght -> fedTrailer.fragmentLength
jenkins tests pass and comparisons with the baseline show no relevant differences
- ignoring random differences in 2018 workflows introduced by 2018 HCAL HB/HE Digi size customization #21651 and affecting HCAL energies used in HLT

mommsen · 2017-12-15T08:26:22Z

+1

ghellwig · 2017-12-15T09:05:36Z

+1

civanch · 2017-12-15T20:27:25Z

+1

davidlange6 · 2017-12-18T08:19:16Z

merge

Remove duplicated code used to decode FED header and trailer informat…

1515c93

…ion.

cmsbuild added this to the CMSSW_10_0_X milestone Dec 12, 2017

cmsbuild added alca-pending code-checks-pending comparison-pending daq-pending dqm-pending l1-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Dec 12, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 12, 2017

cmsbuild added tests-started and removed tests-pending labels Dec 12, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Dec 12, 2017

mommsen added 2 commits December 13, 2017 12:29

Add EvFFEDSelector to plugins

ca2403a

Use name 'fragmentLength' to access the length of the event fragment

26cf0d9

cmsbuild added tests-started and removed tests-pending labels Dec 13, 2017

cmsbuild added tests-approved and removed tests-started labels Dec 13, 2017

cmsbuild added comparison-available and removed comparison-pending labels Dec 13, 2017

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 14, 2017

cmsbuild added daq-approved and removed daq-pending labels Dec 15, 2017

cmsbuild added alca-approved and removed alca-pending labels Dec 15, 2017

cmsbuild added simulation-approved and removed simulation-pending labels Dec 15, 2017

cmsbuild added orp-approved and removed orp-pending labels Dec 18, 2017

cmsbuild merged commit d15c253 into cms-sw:master Dec 18, 2017

slava77 mentioned this pull request Dec 18, 2017

Online meta data format #21436

Merged

mommsen deleted the cleanupFedInterface branch December 18, 2017 13:00

This was referenced Jan 9, 2018

FEDTrailer/FEDHeader needs a namespace #14353

Closed

Duplicate header for fed_trailer.h #21312

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove duplicated code used to decode FED header and trailer #21690

Remove duplicated code used to decode FED header and trailer #21690

mommsen commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

mommsen commented Dec 12, 2017

cmsbuild commented Dec 12, 2017 •

edited

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 13, 2017

cmsbuild commented Dec 13, 2017

cmsbuild commented Dec 13, 2017

cmsbuild commented Dec 13, 2017

slava77 commented Dec 14, 2017

mommsen commented Dec 15, 2017

ghellwig commented Dec 15, 2017

civanch commented Dec 15, 2017

davidlange6 commented Dec 18, 2017

Remove duplicated code used to decode FED header and trailer #21690

Remove duplicated code used to decode FED header and trailer #21690

Conversation

mommsen commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

mommsen commented Dec 12, 2017

cmsbuild commented Dec 12, 2017 • edited

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 12, 2017

cmsbuild commented Dec 13, 2017

cmsbuild commented Dec 13, 2017

cmsbuild commented Dec 13, 2017

cmsbuild commented Dec 13, 2017

slava77 commented Dec 14, 2017

mommsen commented Dec 15, 2017

ghellwig commented Dec 15, 2017

civanch commented Dec 15, 2017

davidlange6 commented Dec 18, 2017

cmsbuild commented Dec 12, 2017 •

edited