Modifications to HCAL trigger LUTs #22121
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22121/3249 |
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: CalibCalorimetry/HcalAlgos @ghellwig, @cmsbuild, @arunhep, @cerminar, @nsmith-, @rekovic, @franzoni, @thomreis, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
Chris, how difficult would be to get correctionPhaseNS from HcalRecoParams |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
The pull request was opened with the understanding that a commit with the needed change to the GTs would be provided [1] by @arunhep. This commit is not yet included, and so the comparison tests will show more discrepancies than expected due to the 13% discrepancy mentioned in the initial message opening this PR. @abdoulline This should be possible, though it's not the completely trivial change that one might expect. I'm looking into how to implement your request. [1] https://hypernews.cern.ch/HyperNews/CMS/get/calibrations/3478/1.html |
cmsbuild
added
code-checks-pending
and removed
code-checks-approved
comparison-available
tests-approved
labels
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
The changes in the comparison test are as expected:
|
|
+1 from L1T DPG |
|
+1 |
|
+1 |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@lpernie I see a comment about a corresponding change in the GT needed to avoid a global shift in the TP scale. Is this addressed? |
|
@fabiocos @lpernie The only needed change in conditions is an update of the HcalLutMetadataRcd to the HcalLutMetadata_2018_v6.0_mc tag. This is exactly what is provided by the commit 7cbf668 from @arunhep: https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/100X_upgrade2018_design_IdealBS_v7/100X_upgrade2018_design_IdealBS_v6 |
|
@lpernie @christopheralanwest thanks for the clarification |
|
+1 |
This PR makes several changes to the generation of the LUTs for HCAL trigger primitive generation:
There are also two minor technical changes:
No changes are expected for any quantity that does not use HCAL TPs. In particular, the changes in the pulse shape classes simply provide a different way to initialize the pulse shape information from conditions.
At a recent L1 Trigger Primitives meeting [1], the L1 DPG signed off on the HCAL trigger group's plan to modify the LUT generation procedure. More details can be found in the presentation from that meeting.
For consistency, the HcalLutMetadata conditions should be changed simultaneously with the code, or else an undesired 13% change in the HBHE TP scale will result. For this reason, I'm requesting the update in the 2018 MC GTs.
[1] https://indico.cern.ch/event/700828/