Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete integration of HP beamspot workflow for PCL #22299

Merged
merged 10 commits into from Feb 24, 2018

Conversation

cerminar
Copy link
Contributor

This PR completes the work needed to feed High-Precision beamspot measurements out of PCL to the LHC.

Dedicated workflow names are introduced duplicating the config. w.r.t to the normal workflow to allow for customization of the selections dropping confusing customization functions. (eventually we might drop the old version).

Relvals and ConfigDP tests are updated accordingly.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cerminar for master.

It involves the following packages:

Calibration/TkAlCaRecoProducers
Configuration/AlCa
Configuration/DataProcessing
Configuration/EventContent
Configuration/PyReleaseValidation
Configuration/StandardSequences

@ghellwig, @prebello, @arunhep, @cerminar, @fabozzi, @cmsbuild, @franzoni, @kpedro88, @GurpreetSinghChahal, @davidlange6, @fabiocos, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @tocheng, @VinInn, @Martin-Grunewald, @ebrondol, @rovere, @mmusich, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@franzoni
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 22, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26235/console Started: 2018/02/22 15:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22299/26235/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2498056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497879
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.05000000011 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

@fabozzi
Copy link
Contributor

fabozzi commented Feb 23, 2018

+1

@lpernie
Copy link
Contributor

lpernie commented Feb 23, 2018

+1

@kpedro88
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

+operations

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants