HCALDQM: Fix digi size reference for summary plots (10_1_X)

[DryRun]

Fixes the digi size reference (HB, HE from 10 to 8) for the summary plots. Also moves the location of the reference from C++ (HcalCommon/interface/Constants.h) to python (DigiTask.py, and copied via import to HcalOnlineHarvesting.py and HcalOfflineHarvesting.py).

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22595/3930

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26823/console Started: 2018/03/13 16:18

[cmsbuild]

+1
Tested at: 0d87ba1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22595/26823/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22595/26823/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2477528
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477348
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.26000000012 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

The error seems to be unrelated to this PR.

Begin processing the 60th record. Run 1, Event 60, LumiSection 1 on stream 0 at 20-Mar-2018 12:04:36.605 CET
%MSG-e MissingProduct:  HybridClusterProducer:cleanedHybridSuperClusters  20-Mar-2018 12:04:37 CET Run: 1 Event: 60
could not get a handle on the EcalRecHitCollection!
%MSG
%MSG-e MissingProduct:  HybridClusterProducer:uncleanedHybridSuperClusters  20-Mar-2018 12:04:37 CET Run: 1 Event: 60
could not get a handle on the EcalRecHitCollection!
%MSG
----- Begin Fatal Exception 20-Mar-2018 12:04:37 CET-----------------------
An exception of category 'fastsim::ParticleManager' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 60 stream: 0
   [1] Running path 'simulation_step'
   [2] Calling method for module FastSimProducer/'fastSimProducer'
Exception Message:
unknown pdg id: 9010221
----- End Fatal Exception -------------------------------------------------
%MSG-w PFEGammaAlgo::mergeROsByAnyLink:  PFEGammaProducer:particleFlowEGamma  20-Mar-2018 12:04:37 CET Run: 1 Event: 57
Need to implement proper merging of two gsf candidates!
%MSG

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27065/console Started: 2018/03/23 11:16

[cmsbuild]

+1
Tested at: c02a24b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22595/27065/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22595/27065/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2497880
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2497700
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.10000000017 KiB( 23 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1