DQM: SiPixelPhase1- Added Big Pixel Charge Plots [Backport for 10_1_X of #22324 ]

[boudoul]

Added the charge of the big pixels for the barrel and the forward region, as well as per layer and per disk
For inclusive clusters and on-track clusters (for inclusive clusters the plots are disabled by default)

Exact backport of the already merged PR #22324

Work done by @emacdonald16

[cmsbuild]

A new Pull Request was created by @boudoul (boudoul) for CMSSW_10_1_X.

It involves the following packages:

DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1TrackClusters
DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@hdelanno, @battibass, @threus, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @mtosi, @idebruyn, @rociovilar, @trocino, @folguera, @fioriNTU this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27277/console Started: 2018/04/04 19:30

[cmsbuild]

+1
Tested at: c9b4419
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22844/27277/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22844/27277/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501879
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501702
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 88.38 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

This PR is quite different from #22324
Can these differences be explained?

[boudoul]

I do not see any differences...

[boudoul]

Hi @dmitrijus , @jfernan2 , what are the differences ?

[boudoul]

I guess you meant for differences the whitespaces introduced by the @emacdonald16's editor ?
you can get the original PR without white spaces (almost ) with https://github.com/cms-sw/cmssw/pull/22324/files?w=1 so that you can see that this PR is the exact backport of the code

[cmsbuild]

Pull request #22844 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[cmsbuild]

Pull request #22844 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[boudoul]

voila I backported the white spaces ...... so everything is strictly in synch .
@dmitrijus , @jfernan2

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27370/console Started: 2018/04/07 09:42

[cmsbuild]

+1
Tested at: 5fa8aef
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22844/27370/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22844/27370/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2504051
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2503874
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 88.5600000002 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

@jfernan2 @dmitrijus do you see any issue with this PR?

[boudoul]

@jfernan2 @dmitrijus : please sign and request this to be in the next 10_1 release (since we missed the 10_1_1)

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1