Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make legacy and uROS DT packer naming consistent for InputTag cfg parameter [10_2_X] #23091

Merged
merged 1 commit into from May 3, 2018

Conversation

battibass
Copy link

@battibass battibass commented Apr 28, 2018

This PR makes the legacy and uROS packer input tag cfg parameter names consistent.

It is expected to have impact on premixing workflows as it makes this line work in the expected way.

It should be addressing (at the bare minimum a fraction of) the issues observed in 102X/101X for muons for premixing.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @battibass (Carlo Battilana) for master.

It involves the following packages:

EventFilter/DTRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Apr 28, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 28, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27711/console Started: 2018/04/28 15:47

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23091/27711/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2495054
  • DQMHistoTests: Total failures: 2032
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2492846
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 28 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@makortel
Copy link
Contributor

@cmsbuild, please test

Let's try again now that we (should) have a premixing workflow in the PR tests.

@slava77
Copy link
Contributor

slava77 commented May 2, 2018

+1

for #23091 e6246b2

  • changes in the code are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show differences only in the premixing workflow 250202.181: there are more DT segments, followed by related changes in the objects made downstream
    • for the comparisons, I ignored numerous small changes in most of the workflows in DQM plots including fits (these fit the pattern "_Mean\|_Sigma\|SigmaTest_W\|MeanTest_W\|mean_delta")

@cmsbuild
Copy link
Contributor

cmsbuild commented May 2, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@slava77
Copy link
Contributor

slava77 commented May 3, 2018

@cmsbuild please test

to get reco comparisons as well after cms-sw/cms-bot#981

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27769/console Started: 2018/05/03 14:37

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented May 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23091/27769/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 612 differences found in the comparisons
  • DQMHistoTests: Total files compared: 30
  • DQMHistoTests: Total histograms compared: 2721257
  • DQMHistoTests: Total failures: 2352
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2718722
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 30 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

@slava77 the new run still show differences just in the wf 250202.181

@fabiocos
Copy link
Contributor

fabiocos commented May 3, 2018

+1

@cmsbuild cmsbuild merged commit 14eea94 into cms-sw:master May 3, 2018
@battibass battibass deleted the uROSPackerInputTag102X branch April 5, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants