[L1T][DQMOffline] Added PFMetNoMu to L1T Offline DQM #23476
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23476/5024 |
|
A new Pull Request was created by @kreczko (Luke Kreczko) for master. It involves the following packages: DQMOffline/L1Trigger @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
cmsbuild
added
fully-signed
l1-approved
and removed
l1-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
The code-checks are being triggered in jenkins. |
|
@fabiocos thanks for the ping - now done |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23476/5067 |
|
Pull request #23476 was updated. @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please check and sign again. |
|
+1 |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
The third part of https://its.cern.ch/jira/browse/CMSLITDPG-588.
Adds
PFMetNoMuas defined in https://github.com/cms-l1t-offline/cmssw/blob/l1t-integration-v97.28/L1Trigger/L1TNtuples/plugins/L1JetRecoTreeProducer.cc#L482Example plots are shown in the jira issue.
However, instead of copying the code from the L1TNuples I added a producer,
L1TPFMetNoMuProducer. This should provide a more clear separation between creating the objects and filling histograms.As for the PFJet issue (#23458 ) the new module dependency,
l1tPFMetNoMuForDQM, should be picked up automagically by CMSSW unscheduled running.Part 4 (minor fixes) will follow shortly.