[L1T][DQMOffline] CaloJets -> PFJets for L1T Offline DQM #23458
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-23458/4996 |
|
A new Pull Request was created by @kreczko (Luke Kreczko) for master. It involves the following packages: DQMOffline/L1Trigger @cmsbuild, @vazzolini, @kmaeshima, @dmitrijus, @nsmith-, @rekovic, @jfernan2, @thomreis, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
| completeSelection = 'et > 30 && (' + ' || '.join([centralJetSelection, withinTrackerSelection, | ||
| forwardJetSelection, veryForwardJetSelection]) + ')' | ||
|
|
||
| goodPFJetsForL1T = cms.EDFilter( |
There was a problem hiding this comment.
Is this filter creating a new collection with selected PF jets (then it should rather be an EDProducer) or is it just filtering events based on the PF jet selection?
If this filter is filtering events based on the PF jet selection it needs to be in a separate path since otherwise the other offline analysis will be biased by the PF jet selected dataset.
I did not see goodPFJetsForL1T in any sequence except the testing one.
There was a problem hiding this comment.
PFJetSelector is an existing EDFilter that will produce a new collection.
goodPFJetsForL1T is added to the process when the DQM module is imported so CMSSW unscheduled processing should pick it up (that's what consumes should take care off).
The only reason I added it to the test config is that I did not want to change to unscheduled mode (many changes).
Of course, this assumes that DQM nowadays runs in unscheduled mode (AFAIK all official modules should).
There was a problem hiding this comment.
You are right. Thanks for the clarification.
|
please test |
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
+1 |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
dqm-approved
fully-signed
and removed
dqm-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
The second part of https://its.cern.ch/jira/browse/CMSLITDPG-588.
Replaces
caloJetswithpfJets(withTightLepVetoas per https://twiki.cern.ch/twiki/bin/view/CMS/JetID13TeVRun2017).Part 3 (PFMetNoMu) and Part 4 (minor fixes) will follow shortly.