Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for AlCaSiStripCalMinBias as discussed on PR #23498 #23523

Merged
merged 1 commit into from Jun 11, 2018

Conversation

jfernan2
Copy link
Contributor

@jfernan2 jfernan2 commented Jun 7, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

The code-checks are being triggered in jenkins.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jun 7, 2018

Tries to fix: #23498
Tk-DQM crew please check:
@boudoul @fioriNTU @dimattia
FYI:
@lpernie @arunhep @fabiocos @franzoni @mmusich

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jun 7, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28548/console Started: 2018/06/07 20:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

A new Pull Request was created by @jfernan2 for master.

It involves the following packages:

DQMOffline/CalibTracker

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@threus, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor

mmusich commented Jun 7, 2018

hi @jfernan2, thanks for this, it would be interesting to get this tested together with #23498.
Would it be possible to abort the test and test them together?
Thanks!

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jun 7, 2018

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

Jenkins tests are aborted.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jun 7, 2018

please test with #23498

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28550/console Started: 2018/06/07 22:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

-1

Tested at: ace1e99

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
615cada
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23523/28550/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23523/28550/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23523/28550/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
615cada
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23523/28550/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23523/28550/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison job queued.

@jfernan2
Copy link
Contributor Author

jfernan2 commented Jun 8, 2018

please test with #23498
it seems unrelated...

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/28552/console Started: 2018/06/08 10:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-23523/28552/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2902499
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2902307
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -1.64 KiB( 30 files compared)
  • DQMHistoSizes: changed ( 136.85,... ): -0.328 KiB AlCaReco/SiStripCalMinBias
  • Checked 128 log files, 14 edm output root files, 31 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Jun 10, 2018

@jfernan2 could you sign also this?

@jfernan2
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9953083 into cms-sw:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants