New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of code for the "jet toolbox" #2414
Conversation
…tToolbox Just making sure my code is up to date
A new Pull Request was created by @jstupak for CMSSW_7_1_X. Addition of code for the "jet toolbox" It involves the following packages: RecoJets/JetAlgorithms @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
@@ -12,4 +12,6 @@ | |||
<use name="CondFormats/JetMETObjects"/> | |||
<use name="JetMETCorrections/Objects"/> | |||
<use name="fastjet"/> | |||
<use name="fastjet-contrib"/> | |||
<use name="DataFormats/PatCandidates"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot have RecoJets depending on PatCandidates.
Hi, Guys, Unfortunately, this violates a large number of CMSSW rules and coding practices. Since there are so many, I will comment on individual lines in addition to this overall comment.
It goes without saying that the right thing to do here is to get a proper CondDB implementation of the XML files instead of dropping the text files into the reco packages. This isn't infinite work, so there's no particular reason we can't just do it. In addition to incorrect coding procedures, there are also a number of things wrong:
I will comment on the individual lines for clarity. |
std::map<TString, std::vector<Float_t>* > products; | ||
for(TString product : {"qg","axis1", "axis2","mult","ptD"}){ | ||
products[product + "Likelihood"] = new std::vector<Float_t>; | ||
products[product + "MLP"] = new std::vector<Float_t>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keeping this as a map of products with strings as the key needs to be changed, this is far too slow for a reco package.
Addition of code for gluon tagging, pileup jet ID, Nsubjettiness, and QJets volatility. This code will be used as part of the "jet toolbox."