Addition of code for nSubjettiness and QJets

[jstupak]

Yesterday I submitted a pull request (#2414) with the nSubjettiness and QJets code, along with code for gluon tagging and pileup ID. The gluon tagging and pileup ID code needs some work, but (I hope) all the code in this pull request is okay.

[cmsbuild]

A new Pull Request was created by @jstupak for CMSSW_7_1_X.

Addition of code for nSubjettiness and QJets

It involves the following packages:

RecoJets/JetAlgorithms
RecoJets/JetProducers

@nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2429/165/summary.html

[rappoccio]

Hi, Folks,

What's the status of this PR? Any action items from the JME side?

Cheers,
Sal

[davidlange6]

this PR only has new files (except for a trivial inclusion of a plugin). Any reason not to include it?
@slava77, @anton-a?

[slava77]

working on it

[slava77]

Please use more unique include guards

[slava77]

Since the code is not run in regular sequences, only follow up to code review (see comments posted) and compilation is necessary from our side

[slava77]

-1

based on the code review
There is no need to close this PR, feel free to provide fixes and update your branch jstupak:nSubJetti_qJets to get this PR updated automatically

[jstupak]

All modifications requested by Slava are now in the repo, with one exception; The QJets code still uses system random functions. Is it really necessary to switch to CMS random engines given this will not be run in the standard sequence?

[cmsbuild]

Pull request #2429 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

[slava77]

Hi John,

Please change the random generator setting as well.
Something like the one below should do, I think

 edm::Service<edm::RandomNumberGenerator> rng;
 CLHEP::HepRandomEngine* engine = &rng->getEngine(iEvent.streamID());
 float xFrom0To1 = engine->flat();

[jstupak]

All of Slava's modifications are now implemented

[cmsbuild]

Pull request #2429 was updated. @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please check and sign again.

[slava77]

+1

for #2429 3770d1d
compiles OK. not used anywhere at this point.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[cmsbuild]

+1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2429/354/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?