MTD Tracking Part 1 - Topology, Geometry, and Tracking Geometry #24285
Conversation
|
@cmsbuild please test |
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24285/6016 Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24285/6016/git-diff.patch You can run |
|
This code check is probably going to add every single sign off... |
lgray
force-pushed
the
mtd_geometries_part1
branch
from
2b00324
to
b807f5e
Compare
|
@cmsbuild please test ok it wasn't so bad.... |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24285/6017 |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @lgray (Lindsey Gray) for master. It involves the following packages: CondFormats/AlignmentRecord The following packages do not have a category, yet: Geometry/MTDGeometryBuilder @perrotta, @civanch, @Dr15Jones, @arunhep, @ianna, @mdhildreth, @cmsbuild, @franzoni, @tocheng, @slava77, @ggovi, @pohsun, @kpedro88, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
The tests are being triggered in jenkins. |
|
+1 |
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
cmsbuild
added
alca-approved
fully-signed
and removed
alca-pending
pending-signatures
labels
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 a list of pending issues has been compiled in #24452, but the integration of this PR will make easier the following steps |
|
|
||
| //double PI = 3.141592654; | ||
|
|
||
| class ModuleNumbering : public edm::one::EDAnalyzer<> { |
There was a problem hiding this comment.
this is a duplicate class and plugin wrt Geometry/TrackerNumberingBuilder/test/ModuleNumbering.cc
our standard duplicate plugin checks notice it
duplicateReflexLibrarySearch.py --edmFile $CMSSW_BASE/lib/$SCRAM_ARCH/.edmplugincache --edmPD
it's unclear if both libraries are ever loaded in the same application.
If they do, this is a source of strange problems.
There was a problem hiding this comment.
@Dr15Jones @smuzaffar
please take a note, in case this is not already known from the standard QA checks.
There was a problem hiding this comment.
@slava77 , yes this is part of standard QA tests for IBs ( https://cmssdt.cern.ch/SDT/cgi-bin/newQA.py?arch=slc6_amd64_gcc700&release=CMSSW_10_3_X_2018-09-25-1100#dupDict ) and also part of PR test (e.g https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24654/30608/dupDict/ ) . May be we should start marking PR test failed if such duplicates are found.
There was a problem hiding this comment.
I have prepared a fix for it in #24680
Even if there could still be some duplicate code (I did not check, in fact) it is in a \test area and it can be modified later on for possible MTD tests (which is the reason why they duplicated some code in this PR)
| @@ -1,5 +1,6 @@ | |||
| <use name="Geometry/CommonDetUnit"/> | |||
| <use name="Geometry/TrackerGeometryBuilder"/> | |||
| <use name="Geometry/TrackerGeometryBuilder"/> | |||
There was a problem hiding this comment.
Hi @lgray , you duplicted this line, is this a bug ?
This pull request introduces all necessary changes to automatically generate MTD Topology, Geometry, and DetLayerGeometry necessary for digitization and tracking. It also introduces the notion of a FTLTrackingRecHit in its first revision, which will evolve in Part 2. I chose the present breakpoint since the number of packages to recompile was starting to become rather large, it would be good to introduce these changes into CMSSW so that further development can be faster and more focused.
The MTDGeometry is implemented similar to the phase 2 tracker geometry, with a geography up to the modules being described in detail, and then individual descriptions of varying module types indicating the pixel topology in rows, columns, and ROCs.
The GlobalTrackingGeometry class is extended to understand that the MTD exists.
Part 2 to begin to address the extensions of the track class, and implement the proper navigation and hit assignment mechanisms.
@fabiocos The one thing that remains for the BTL part of the geometry is to write the mapping between the crystal number in the det id and the row/column and ROC number as it is done in the Pixel Topologies. This should be quick.
@fabiocos @bendavid @casarsa