New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BMTF fixes for the AlgoSelector and the Unpacker #24652
BMTF fixes for the AlgoSelector and the Unpacker #24652
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24652/6557 |
A new Pull Request was created by @panoskatsoulis for master. It involves the following packages: DQM/L1TMonitor @cmsbuild, @andrius-k, @kmaeshima, @schneiml, @nsmith-, @rekovic, @jfernan2, @thomreis can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
please test workflow 134.813,136.8562 |
The tests are being triggered in jenkins. |
privately tested to fix the crashing workflows |
@fabiocos |
Comparison job queued. |
@panoskatsoulis the problem is fixed, as you may see in https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24652/30638/runTheMatrix-results/ the crashing workflows completed smoothly |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
@thomreis @andrius-k this PR looks to fix the recent crashes we have observed in the IB, see the tests. Could you please comment or sign it so as we fix this issue? |
+1 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Includes 2 fixes:
a) Fixes the L1TBMTFAlgoSelector SEGFAULT issue when there is no MP7 header to read by introducing a default configuration for the DQM Fix logic.
b) Fixes issue that lies in one BMTFUnpacker Constructor and leaves the 'isKalman' boolean undefined.