SiStrip unpacker: update packet code check in cmMedian (for nonstandard ZS modes)

[pieterdavid]

This is a bug fix for the method that extracts the CM medians from ZS raw data. It contains a protection to prevent extracting CM medians for non-ZS modes (because they are not present then), but that did not take the nonstandard packet codes into account yet, so an exception was thrown (and caught and converted into warning by the calling code) when unpacking with UnpackCommonModeValues = True.
As far as I know this feature is only used for specific studies of the zero-suppression settings, so there is no urgent need to have this in a release.

CC: @CesarBernardes @alesaggio

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24812/6757

[cmsbuild]

A new Pull Request was created by @pieterdavid (Pieter David) for master.

It involves the following packages:

EventFilter/SiStripRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30898/console Started: 2018/10/05 14:39

[cmsbuild]

+1
Tested at: 773d249
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24812/30898/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24812/30898/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3162979
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3162781
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #24812 773d249

• implemented as described (as said in the PR description, this currently affects only non-production setups used in analysis or testing)
• jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[slava77]

@fabiocos
please check this and merge or clarify if there are any pending issues.
Thank you.

[fabiocos]

@slava77 @pieterdavid I understand this is not effectively tested in the regular procedure, was a test done offline?

[pieterdavid]

@fabiocos yes, @CesarBernardes tested it.

[CesarBernardes]

@fabiocos hi, yes, I could access properly the common mode information from FED calculation after this fix. Thanks.

[fabiocos]

+1