Raw data remapper #24819
Raw data remapper #24819
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-24819/6765 |
|
A new Pull Request was created by @icali (Ivan Amos Cali) for master. It involves the following packages: EventFilter/RawDataCollector @mommsen, @cmsbuild, @emeschi can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
@cmsbuild please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: 0707979 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build ClangBuild
I found an error when building: >> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-10-06-1100/src/EventFilter/RawDataCollector/src/RawDataFEDSelector.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-10-06-1100/src/EventFilter/RawDataCollector/src/RawDataCollectorByLabel.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-10-06-1100/src/EventFilter/RawDataCollector/src/RawDataMapperByLabel.cc
>> Compiling edm plugin /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-10-06-1100/src/EventFilter/RawDataCollector/src/SealModule.cc
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-10-06-1100/src/EventFilter/RawDataCollector/src/RawDataMapperByLabel.cc: In constructor 'RawDataMapperByLabel::RawDataMapperByLabel(const edm::ParameterSet&)':
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_3_X_2018-10-06-1100/src/EventFilter/RawDataCollector/src/RawDataMapperByLabel.cc:27:3: error: 'verbose_' was not declared in this scope
verbose_ = pset.getUntrackedParameter("verbose",0);
^~~~~~~~
gmake: *** [tmp/slc6_amd64_gcc700/src/EventFilter/RawDataCollector/src/EventFilterRawDataCollector/RawDataMapperByLabel.cc.o] Error 1
>> Building edm plugin tmp/slc6_amd64_gcc700/src/EventFilter/RawDataCollector/src/EventFilterRawDataCollector/libEventFilterRawDataCollector.so
c++: error: tmp/slc6_amd64_gcc700/src/EventFilter/RawDataCollector/src/EventFilterRawDataCollector/RawDataMapperByLabel.cc.o: No such file or directory
I found a compilation error while trying to compile with clang: >> Local Products Rules ..... started >> Local Products Rules ..... done >> Creating project symlinks >> Entering Package EventFilter/RawDataCollector >> Compile sequence completed for CMSSW CMSSW_10_3_X_2018-10-06-1100 gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 1 |
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
|
@cmsbuild please test @icali |
|
The tests are being triggered in jenkins. |
|
Hi, not yet. Trying to find the correct syntax.
… On Oct 14, 2018, at 10:28 AM, Slava Krutelyov ***@***.***> wrote:
@cmsbuild <https://github.com/cmsbuild> please test
@icali <https://github.com/icali>
were you able to resolve the run time issues (mentioned/related to #24819 (comment) <#24819 (comment)>)?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#24819 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEzdrij7D2IzVgANgMS2ab2c_do2-ZaAks5ukvWxgaJpZM4XLxhq>.
|
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
cmsbuild
added
daq-approved
fully-signed
and removed
daq-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@icali @slava77 sorry, I am a bit confused by #24819 (comment) : the module is technically compiling, and aesthetically clean, but in practice it hangs if used in a real workflow? Or am I misinterpreting the comment? |
|
+1 |
First implementation of the ReMapper.
It should contains all the features as discussed in the #24619 (comment)
Please comment of what you think is missing or how it should be modified. Also the naming of the module could be adjusted.