[10_2_X] DeepDoubleCvL and DeepDoubleCvB tagger integration #25370

andrzejnovak · 2018-11-29T11:25:14Z

Backport of #24918

Dependent on cms-data/RecoBTag-Combined#19

cmsbuild · 2018-11-29T11:25:36Z

A new Pull Request was created by @andrzejnovak (Andrzej Novak) for CMSSW_10_2_X.

It involves the following packages:

DataFormats/BTauReco
PhysicsTools/PatAlgos
RecoBTag/Configuration
RecoBTag/FeatureTools
RecoBTag/TensorFlow

@perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @hqucms, @ferencek, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Backported from DeepDoubleCvL and DeepDoubleCvB tagger integration #24918

slava77 · 2018-12-04T17:39:33Z

@cmsbuild please test with cms-sw/cmsdist#4550

cmsbuild · 2018-12-04T17:39:51Z

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4550
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31994/console

slava77 · 2018-12-04T17:49:59Z

PhysicsTools/PatAlgos/python/slimming/applyDeepBtagging_cff.py

-#        ] + pfDeepBoostedJetTagsAll,  # uncomment it to test DeepBoostedJet
-       postfix = 'SlimmedAK8DeepTags'+postfix,
+          #'pfDeepDoubleCvLJetTags:probQCD',
+          #'pfDeepDoubleCvLJetTags:probHcc',


in some recent backports for miniAOD we actually allowed additions of variables in a similar context (one latest example was the photon IDs).
So, I think that the same can be done here as well.

slava77 · 2018-12-04T19:37:05Z

PhysicsTools/PatAlgos/python/recoLayer0/bTagging_cff.py

@@ -189,8 +189,18 @@
  , 'pfNegativeDeepFlavourJetTags:probc'                            : [["pfNegativeDeepFlavourTagInfos"], ['pfDeepCSVNegativeTagInfos', "pfImpactParameterTagInfos", 'pfInclusiveSecondaryVertexFinderNegativeTagInfos']]
  , 'pfNegativeDeepFlavourJetTags:probuds'                          : [["pfNegativeDeepFlavourTagInfos"], ['pfDeepCSVNegativeTagInfos', "pfImpactParameterTagInfos", 'pfInclusiveSecondaryVertexFinderNegativeTagInfos']]
  , 'pfNegativeDeepFlavourJetTags:probg'                            : [["pfNegativeDeepFlavourTagInfos"], ['pfDeepCSVNegativeTagInfos', "pfImpactParameterTagInfos", 'pfInclusiveSecondaryVertexFinderNegativeTagInfos']]
-  , 'pfDeepDoubleBJetTags:probQ'                            : [["pfDeepDoubleBTagInfos"], ['pfBoostedDoubleSVAK8TagInfos', "pfImpactParameterAK8TagInfos", 'pfInclusiveSecondaryVertexFinderAK8TagInfos']]
-  , 'pfDeepDoubleBJetTags:probH'                            : [["pfDeepDoubleBTagInfos"], ['pfBoostedDoubleSVAK8TagInfos', "pfImpactParameterAK8TagInfos", 'pfInclusiveSecondaryVertexFinderAK8TagInfos']]
+  , 'pfDeepDoubleBJetTags:probQ'                     : [["pfDeepDoubleXTagInfos"], ['pfBoostedDoubleSVAK8TagInfos', "pfImpactParameterAK8TagInfos", 'pfInclusiveSecondaryVertexFinderAK8TagInfos']]


considering the change in the naming scheme, I think that we can both satisfy the no-change policy and also provide the new taggers.
Simply

leave the old-named taggers configured to use the old training so that it computes the same/old values

and add the new BvLTags
There is a bit of cost increase in CPU, but it should be tolerable.

slava77 · 2018-12-04T19:50:57Z

RecoBTag/TensorFlow/test/plotDDX.py

+    jets = handleJ.product()
+    for jet in jets  :
+        #if jet.pt() < 300 or jet.pt() > 2000: continue
+        #if jet.mass() < 40 or jet.mass() > 200: continue


these conditions are not commented out in the master version.
Please keep it consistent

cmsbuild · 2018-12-04T20:14:09Z

+1
Tested at: 550912e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/31994/summary.html

cmsbuild · 2018-12-04T20:14:17Z

Comparison job queued.

cmsbuild · 2018-12-04T21:31:05Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/31994/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 38 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 3007299
DQMHistoTests: Total failures: 2
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3007107
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

cmsbuild · 2018-12-14T14:02:31Z

The tests are being triggered in jenkins.

PhysicsTools/PatAlgos/python/slimming/applyDeepBtagging_cff.py

cmsbuild · 2018-12-14T14:21:13Z

Pull request #25370 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

andrzejnovak · 2018-12-14T14:43:13Z

@slava77 @fabiocos Updated to include pfDeepBoostedJetTagsAll after all for the run2_miniAOD_devel please test

slava77 · 2018-12-14T14:53:50Z

@cmsbuild please test

cmsbuild · 2018-12-14T14:54:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32201/console Started: 2018/12/14 18:49

cmsbuild · 2018-12-14T20:54:47Z

+1
Tested at: 0ce117f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/32201/summary.html

cmsbuild · 2018-12-14T20:54:51Z

Comparison job queued.

cmsbuild · 2018-12-14T22:46:42Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25370/32201/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 31
DQMHistoTests: Total histograms compared: 3007400
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3007206
DQMHistoTests: Total skipped: 190
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
Checked 129 log files, 14 edm output root files, 31 DQM output files

slava77 · 2018-12-17T17:44:16Z

+1

for #25370 0ce117f

code changes are in line with the PR description and the follow up review:
- after the last reco signoff for [10_2_X] DeepDoubleCvL and DeepDoubleCvB tagger integration #25370 b0c7783 this PR was updated to use the recently introduced run2_miniAOD_devel in order to strictly satisfy the no-change policy.
jenkins tests pass and comparisons with the baseline show no differences
local checks based on expanded configs show that this code runs as expected with run2_miniAOD_devel and creates the additional jet taggers

fabiocos · 2018-12-19T10:37:57Z

+1

fabiocos · 2018-12-19T10:38:10Z

merge

anovak10 added 6 commits November 27, 2018 10:27

Backporting DeepDoubleX(BvL,CvL,CvB) tagger to 102X

e941c59

adding 102X test file

af818a0

Removing model files from main CMSSW

ba3c15f

Disable new taggers by default

64270d5

updates to main PR

459d506

Fixing JetTags names to be backcompatible

b3fd7a2

cmsbuild added this to the CMSSW_10_2_X milestone Nov 29, 2018

cmsbuild added analysis-pending backport-ok comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Nov 29, 2018

Fixing JetTags part2

550912e

slava77 mentioned this pull request Dec 4, 2018

[10_2_X] Update data-RecoBTag-Combined.spec cms-sw/cmsdist#4550

Merged

cmsbuild added requires-external tests-started and removed tests-pending labels Dec 4, 2018

slava77 reviewed Dec 4, 2018

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Dec 4, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 4, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 14, 2018

slava77 reviewed Dec 14, 2018

View reviewed changes

PhysicsTools/PatAlgos/python/slimming/applyDeepBtagging_cff.py Outdated Show resolved Hide resolved

Sync run2_miniAOD_devel to master

0ce117f

cmsbuild added tests-pending and removed tests-started labels Dec 14, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 14, 2018

slava77 mentioned this pull request Dec 14, 2018

factor out btagDiscriminators definition for easier modification #25501

Merged

cmsbuild added tests-approved and removed tests-started labels Dec 14, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 14, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Dec 17, 2018

cmsbuild added orp-approved and removed orp-pending labels Dec 19, 2018

cmsbuild merged commit 6c1a493 into cms-sw:CMSSW_10_2_X Dec 19, 2018

Dr15Jones mentioned this pull request Mar 14, 2019

Unable to read 2018D data using CMSSW_10_2_10 #26182

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[10_2_X] DeepDoubleCvL and DeepDoubleCvB tagger integration #25370

[10_2_X] DeepDoubleCvL and DeepDoubleCvB tagger integration #25370

andrzejnovak commented Nov 29, 2018

cmsbuild commented Nov 29, 2018 •

edited

slava77 commented Dec 4, 2018

cmsbuild commented Dec 4, 2018 •

edited

slava77 Dec 4, 2018

slava77 Dec 4, 2018

slava77 Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 14, 2018

cmsbuild commented Dec 14, 2018

andrzejnovak commented Dec 14, 2018

slava77 commented Dec 14, 2018

cmsbuild commented Dec 14, 2018 •

edited

cmsbuild commented Dec 14, 2018

cmsbuild commented Dec 14, 2018

cmsbuild commented Dec 14, 2018

slava77 commented Dec 17, 2018

fabiocos commented Dec 19, 2018

fabiocos commented Dec 19, 2018

[10_2_X] DeepDoubleCvL and DeepDoubleCvB tagger integration #25370

[10_2_X] DeepDoubleCvL and DeepDoubleCvB tagger integration #25370

Conversation

andrzejnovak commented Nov 29, 2018

cmsbuild commented Nov 29, 2018 • edited

slava77 commented Dec 4, 2018

cmsbuild commented Dec 4, 2018 • edited

slava77 Dec 4, 2018

Choose a reason for hiding this comment

slava77 Dec 4, 2018

Choose a reason for hiding this comment

slava77 Dec 4, 2018

Choose a reason for hiding this comment

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 14, 2018

cmsbuild commented Dec 14, 2018

andrzejnovak commented Dec 14, 2018

slava77 commented Dec 14, 2018

cmsbuild commented Dec 14, 2018 • edited

cmsbuild commented Dec 14, 2018

cmsbuild commented Dec 14, 2018

cmsbuild commented Dec 14, 2018

slava77 commented Dec 17, 2018

fabiocos commented Dec 19, 2018

fabiocos commented Dec 19, 2018

cmsbuild commented Nov 29, 2018 •

edited

cmsbuild commented Dec 4, 2018 •

edited

cmsbuild commented Dec 14, 2018 •

edited