Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628

bendavid · 2019-01-11T17:47:43Z

(master version of #25627)
Implements changes needed to propagate full simulation and reconstruction based track timestamps to 4D vertex reconstruction and particle flow.
(Previously this was already implemented and running based on the fastsim timestamps used for the MTD Technical Proposal)

The following strategy is used to deal with particles moving slower than the speed of light:

Existing timestamps from the TrackExtender assume the pion mass hypothesis when propagating the MTD cluster time back to the beamline. The valuemaps produced at this step have been extended to provide some additional information in a more convenient form. (Time at MTD, momentum magnitude of refitted track, etc) As well the uncertainty is inflated by adding in quadrature the time of flight difference between the pion and proton mass hypothesis for each track.

First pass of 4D vertex reconstruction runs on the output as above. After a bugfix/protection, combined with the inflated uncertainties it is able to deal with the resulting outliers from slower kaons/protons in a reasonable way.

Additional TOFPIDProducer which tests compatibility of kaon and proton mass hypotheses for the tracks with the 4D vertices from 2) and produces updated timestamps where appropriate. This producer also creates value maps of particle ID probabilities which can be used downstream.

Second pass of 4D vertex reconstruction based on the refined timestamps from 3)

This pull request also migrates the PFCandidate timestamps to the fullsim/reconstruction ones (previously populated from the fastsim). This automatically propagates to the packed candidates in MINIAOD as well.

An additional collection of slimmed primary vertices with timing is added to MINIAOD, but the PackedCandidate-vertex association, puppi, etc are still based on the default primary vertices without timing.

In order to facilitate comparisons and benchmarking, the fastsim-based timestamps and 4d vertex reco is still run and stored. This is especially relevant since direct comparisons may validate the continued use of existing/fastsim-based results where fullsim-based ones are not yet available.

Some discussion and validation/performance plots in https://indico.cern.ch/event/783100/contributions/3273442/attachments/1780769/2896933/mtdvtxJan17-2019.pdf

@pmeridian @lgray

…ime of flight particle id

… populate the default offlinePrimaryVertices collections

cmsbuild · 2019-01-11T17:48:10Z

The code-checks are being triggered in jenkins.

kpedro88 · 2019-01-11T17:48:39Z

assign upgrade

cmsbuild · 2019-01-11T17:54:22Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25628/7942

This PR adds an extra 44KB to repository

cmsbuild · 2019-01-11T17:54:43Z

New categories assigned: upgrade

@kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2019-01-11T17:54:46Z

A new Pull Request was created by @bendavid (Josh Bendavid) for master.

It involves the following packages:

CommonTools/RecoAlgos
RecoMTD/TrackExtender
RecoParticleFlow/PFProducer
RecoVertex/Configuration
RecoVertex/PrimaryVertexProducer

@perrotta, @cmsbuild, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @jdolen, @makortel, @abbiendi, @GiacomoSguazzoni, @mmarionncern, @jhgoh, @lgray, @ahinzmann, @gkasieczka, @bachtis, @cbernet, @ebrondol, @VinInn, @rovere, @dgulhan, @seemasharmafnal, @clelange this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

slava77 · 2019-01-11T17:59:59Z

@cmsbuild please test

cmsbuild · 2019-01-11T18:00:30Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32538/console Started: 2019/01/11 19:01

cmsbuild · 2019-01-11T18:11:31Z

-1

Tested at: f487a29

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25628/32538/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found compilation warning when building: See details on the summary page.

Clang:

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 16 COMPILER='llvm compile'

See details on the summary page.

cmsbuild · 2019-01-11T18:11:34Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

kpedro88 · 2019-01-21T17:31:02Z

+upgrade

andrius-k · 2019-01-22T10:07:40Z

+1

fabiocos · 2019-01-22T13:39:36Z

code-checks

cmsbuild · 2019-01-22T13:40:11Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-22T13:47:09Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25628/8127

This PR adds an extra 180KB to repository
Found files with invalid states:
- CommonTools/RecoAlgos/python/TOFPIDProducer_cfi.py:
  - Added: a0c1929
  - Modified: c834441, f487a29, cbda9a7, b770cf6, f777755, 7810d59
  - Deleted: e1a553e

fabiocos · 2019-01-22T13:48:50Z

PhysicsTools/PatAlgos/python/slimming/slimming_cff.py

+from Configuration.Eras.Modifier_phase2_timing_cff import phase2_timing
+_phase2_timing_slimmingTask = cms.Task(slimmingTask.copy(),
+                                       offlineSlimmedPrimaryVertices4D)
+phase2_timing.toReplaceWith(slimmingTask,_phase2_timing_slimmingTask)


@bendavid @slava77 given the other discussions in the review about phase2_timing vs phase2_timing_layer , is this really the desired behaviour?

Yes, this adds an additional slimmed primary vertex collection to the miniaod. In the case of phase2_timing alone, this corresponds to the fastsim 4d vertices, in the case of phase2_timing_layer, this corresponds to fullsim 4d vertices.

fabiocos · 2019-01-22T13:49:08Z

PhysicsTools/PatAlgos/python/slimming/MicroEventContent_cff.py

+
+_phase2_timing_extraCommands = ["keep *_offlineSlimmedPrimaryVertices4D_*_*"]
+from Configuration.Eras.Modifier_phase2_timing_cff import phase2_timing
+phase2_timing.toModify(MicroEventContentMC, outputCommands = MicroEventContentMC.outputCommands + _phase2_timing_extraCommands)


@bendavid @slava77 given the other discussions in the review about phase2_timing vs phase2_timing_layer , is this really the desired behaviour?

fabiocos · 2019-01-22T21:46:02Z

+1

fabiocos · 2019-01-22T21:46:55Z

merge

fabiocos · 2019-01-23T08:53:02Z

@bendavid @pmeridian @slava77 @kpedro88 this PR is creating problems in the scenario D19, the old MTD simulation, as it crashes in the test 20434.0, see

https://cmssdt.cern.ch/SDT/cgi-bin/logreader/slc6_amd64_gcc700/CMSSW_10_5_X_2019-01-22-2300/pyRelValMatrixLogs/run/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log#/

where in the RECO step3 you get

----- Begin Fatal Exception 23-Jan-2019 05:23:18 CET-----------------------
An exception of category 'ProductNotFound' occurred while
[0] Processing Event run: 1 lumi: 1 event: 5 stream: 1
[1] Running path 'validation_step6'
[2] Prefetching for module CaloParticleValidation/'caloparticlevalidation'
[3] Prefetching for module SimPFProducer/'simPFProducer'
[4] Prefetching for module TOFPIDProducer/'tofPID'
[5] Calling method for module PrimaryVertexProducer/'unsortedOfflinePrimaryVertices4DnoPID'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: edm::ValueMap<float>
Looking for module label: trackExtenderWithMTD
Looking for productInstanceName: generalTracksigmat0

Additional Info:
[a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Do we really want to modify this scenario? My understanding is that @kpedro88 preferred to keep it frozen, waiting for the final new MTD simulation to become official to get rid of it

fabiocos · 2019-01-23T09:53:44Z

@bendavid what is the purpose of touching the old simulation? Wouldn't be simpler just modify (phase2_timing_layer_tile | phase2_timing_layer_bar) ?

bendavid · 2019-01-23T11:42:51Z

Looking at this now, the old scenario was not supposed to be modified here in the end (except for adding the new collection to miniaod which is generic), but since the configuration files for RecoVertex were heavily restructured, probably something was touched by mistake.

bendavid · 2019-01-23T11:56:18Z

Ok, sorry, we're talking about two different things.
Indeed I was not aware of this, will rework the configs to fix it (but it makes things messy, because there will be phase2_timing_layer_tile | phase2_timing_layer_bar now in several places)

fabiocos · 2019-01-23T12:24:19Z

@bendavid ok, I believe now we understand better, please check https://github.com/fabiocos/cmssw/tree/fc-fixMTD4D
where I have implemented this, both 20434.0 and 27434.0 run smoothly till the end (although I did not check the outputs)

bendavid · 2019-01-23T12:43:35Z

This actually would remove parts of the track and vertex validation which were already present in the old scenario (and using fastsim inputs).

I opened a new PR here which should really preserve the existing behaviour (except for adding the additional slimmed collection in miniaod, which would still be useful/desirable in case this is ever used)
#25745

kpedro88 · 2019-01-23T14:29:51Z

(but it makes things messy, because there will be phase2_timing_layer_tile | phase2_timing_layer_bar now in several places)

I suggested a while ago to make a common phase2_timing_layer_new modifier, and then chain the tile- and bar-specific modifications:

phase2_timing_layer_new = cms.Modifier()
phase2_timing_bar = cms.Modifier()
phase2_timing_tile = cms.Modifier()
phase2_timing_layer_bar = cms.ModifierChain(phase2_timing_layer_new, phase2_timing_bar)
phase2_timing_layer_tile = cms.ModifierChain(phase2_timing_layer_new, phase2_timing_tile)

makortel · 2019-01-23T16:48:21Z

@kpedro88

(but it makes things messy, because there will be phase2_timing_layer_tile | phase2_timing_layer_bar now in several places)

I suggested a while ago to make a common phase2_timing_layer_new modifier, and then chain the tile- and bar-specific modifications:
phase2_timing_layer_new = cms.Modifier()
phase2_timing_bar = cms.Modifier()
phase2_timing_tile = cms.Modifier()
phase2_timing_layer_bar = cms.ModifierChain(phase2_timing_layer_new, phase2_timing_bar)
phase2_timing_layer_tile = cms.ModifierChain(phase2_timing_layer_new, phase2_timing_tile)

What would the phase2_timing_layer_bar and phase2_timing_layer_tile be used for?

kpedro88 · 2019-01-23T17:28:17Z

To combine with the Phase2 Era to make top-level Eras for workflows. (Not essential, but possibly worthwhile for organization.)

makortel · 2019-01-23T17:30:09Z

Ok, thanks.

bendavid added 6 commits January 11, 2019 17:40

migrate 4d vertexing to fullsim and first mostly working version of t…

a0c1929

…ime of flight particle id

add protection for infinite loop in 4d vertex reco

b446e6d

migrate PFCandidate times to fullsim/reconstruction

f616a36

produce also fastsim-based 4d vertices for now

48db64e

tweak pid algorithm and add some configurable parameters

c834441

rearrange RecoVertex configuration for timing era so that 4d vertices…

f487a29

… populate the default offlinePrimaryVertices collections

cmsbuild added this to the CMSSW_10_5_X milestone Jan 11, 2019

bendavid mentioned this pull request Jan 11, 2019

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_4_X) #25627

Merged

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 11, 2019

cmsbuild added the upgrade-pending label Jan 11, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 11, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 11, 2019

cmsbuild removed comparison-pending tests-started labels Jan 11, 2019

cmsbuild added upgrade-approved and removed upgrade-pending labels Jan 21, 2019

cmsbuild added dqm-approved and removed dqm-pending labels Jan 22, 2019

cmsbuild added code-checks-pending and removed code-checks-approved labels Jan 22, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 22, 2019

fabiocos reviewed Jan 22, 2019

View reviewed changes

cmsbuild added orp-approved and removed orp-pending labels Jan 22, 2019

cmsbuild merged commit 5500bf2 into cms-sw:master Jan 22, 2019

fabiocos mentioned this pull request Jan 23, 2019

keep phase2_timing_layer functional #25745

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628

bendavid commented Jan 11, 2019 •

edited

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

slava77 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019 •

edited

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 21, 2019

andrius-k commented Jan 22, 2019

fabiocos commented Jan 22, 2019

cmsbuild commented Jan 22, 2019

cmsbuild commented Jan 22, 2019

fabiocos Jan 22, 2019

bendavid Jan 22, 2019

fabiocos Jan 22, 2019

fabiocos commented Jan 22, 2019

fabiocos commented Jan 22, 2019

fabiocos commented Jan 23, 2019

fabiocos commented Jan 23, 2019

bendavid commented Jan 23, 2019

bendavid commented Jan 23, 2019

fabiocos commented Jan 23, 2019 •

edited

bendavid commented Jan 23, 2019

kpedro88 commented Jan 23, 2019

makortel commented Jan 23, 2019

kpedro88 commented Jan 23, 2019

makortel commented Jan 23, 2019

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628

Migrate 4D vertexing and downstream reco to full simulation/reconstruction track timestamps and add TOF PID (10_5_X) #25628

Conversation

bendavid commented Jan 11, 2019 • edited

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

slava77 commented Jan 11, 2019

cmsbuild commented Jan 11, 2019 • edited

cmsbuild commented Jan 11, 2019

cmsbuild commented Jan 11, 2019

kpedro88 commented Jan 21, 2019

andrius-k commented Jan 22, 2019

fabiocos commented Jan 22, 2019

cmsbuild commented Jan 22, 2019

cmsbuild commented Jan 22, 2019

fabiocos Jan 22, 2019

Choose a reason for hiding this comment

bendavid Jan 22, 2019

Choose a reason for hiding this comment

fabiocos Jan 22, 2019

Choose a reason for hiding this comment

fabiocos commented Jan 22, 2019

fabiocos commented Jan 22, 2019

fabiocos commented Jan 23, 2019

fabiocos commented Jan 23, 2019

bendavid commented Jan 23, 2019

bendavid commented Jan 23, 2019

fabiocos commented Jan 23, 2019 • edited

bendavid commented Jan 23, 2019

kpedro88 commented Jan 23, 2019

makortel commented Jan 23, 2019

kpedro88 commented Jan 23, 2019

makortel commented Jan 23, 2019

bendavid commented Jan 11, 2019 •

edited

cmsbuild commented Jan 11, 2019 •

edited

fabiocos commented Jan 23, 2019 •

edited