Herwig7 fix seg fault master

[Andrej-CMS]

PR description:

Dear all,
this is a PR to fix the crash in official production with Herwig7 when the luminosityBlock changed.
Additionally, the PR adds parton shower weights for Herwig 7 as well as a corresponding configs that can be used in production.
Kind regards,
Andrej

PR validation:

To simulate the official production, the code was run on crab, which had the same issue. Just to be sure, we still need to test it in official production that the issue is indeed fully solved.
Output of an example job:
https://cmsweb.cern.ch/scheddmon/0197/cms1305/190523_121600:asaibel_crab_Generator_InitializeOnlyFirstLumi/job_out.3.0.txt

Before the changes, the jobs always failed after the change in luminosity block after 100events. You can see in the job that 350 events (two lumiBlock changes) are produced without failing.

The content of the PS weights was checked by checking the number of weights for each event in the GenEventInfoProduct

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26905/9948

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26905/9948/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26905/9948/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-26905/9950

• This PR adds an extra 36KB to repository

[cmsbuild]

A new Pull Request was created by @Andrej-CMS for master.

It involves the following packages:

Configuration/Generator
GeneratorInterface/Herwig7Interface

@alberto-sanchez, @cmsbuild, @qliphy, @agrohsje, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[efeyazgan]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/457/console Started: 2019/05/23 17:32

[cmsbuild]

+1
Tested at: 1cc0288
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a091bc/457/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a091bc/457/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 7 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3206856
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3206519
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[efeyazgan]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@Andrej-CMS @efeyazgan was the output of the new code checked as well, making some DQM/Rivet comparison?

[Andrej-CMS]

@fabiocos
I didn't run these comparisons. Shouldn't this be part of the jenkins test routines to run work flow 511 ?

[fabiocos]

@Andrej-CMS workflow 511 is not part of the short matrix, nobody triggered its run in this PR, and in any case we do not have a comparison for it even if we trigger its running... This is a basic check I would expect it is done a priori, looking at the output of the code before and after the update. I am not claiming that you need to expect problems, but given that the change is not totally minimal it would be better to check. Not crashing is good, but not enough to be correct.

[Andrej-CMS]

Hello @fabiocos
you can find the output of relval in the file below on lxplus. All tests show perfect agreement between the earlier version and this PR (except that the PR doesn't crash anymore when the lumiBlock changes).

I also pushed an updated version of workflow 535 to 10_2_X and 9_3_X. It would be nice to have this WF running when code related to the generators gets changed. WF 535 is very fast and takes less than a minute for 10 events.

/afs/cern.ch/work/a/asaibel/public/validation_10_2_14_OLD_vs_10_2_14_New/Generator.html

EDIT: forgot to mention that "OLD" means here an unchanged version of the code as it was before this PR. Both times, the workflows were run with the same random seeds.

[fabiocos]

+1