Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DD4Hep: Tracker DDPixPhase1FwdDiskAlgo Migration #27636

Merged
merged 1 commit into from Jul 31, 2019
Merged

DD4Hep: Tracker DDPixPhase1FwdDiskAlgo Migration #27636

merged 1 commit into from Jul 31, 2019

Conversation

vargasa
Copy link
Contributor

@vargasa vargasa commented Jul 30, 2019

PR validation:
cmsRun DetectorDescription/DDCMS/test/python/testDDPixPhase1FwdDiskAlgorithm.py

FYI: @ianna

@vargasa
DD4hep Tracker DDPixPhase1FwdDiskAlgo Migration && test
45d6b32 
    Geometry/TrackerCommonData/plugins/DDPixPhase1FwdDiskAlgo.cc
@cmsbuild cmsbuild added this to the CMSSW_11_0_X milestone Jul 30, 2019
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27636/11135

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vargasa (Andrés Vargas) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 30, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1713/console Started: 2019/07/30 17:58

@cmsbuild
Copy link
Contributor

+1
Tested at: 45d6b32
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88c059/1713/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-88c059/1713/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2628564
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2628246
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@ianna
Copy link
Contributor

ianna commented Jul 30, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ianna
Copy link
Contributor

ianna commented Jul 31, 2019

@fabiocos - please, review

@ianna
Copy link
Contributor

ianna commented Jul 31, 2019

urgent

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3300dc4 into cms-sw:master Jul 31, 2019
@cmsbuild cmsbuild mentioned this pull request Aug 1, 2019
Merged
@vargasa vargasa deleted the DD4hep_PixPhase1FwdDiskAlgo_Mig branch October 9, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed geometry-approved orp-approved tests-approved urgent
Projects
None yet
Milestone
CMSSW_11_0_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@vargasa @cmsbuild @cvuosalo @ianna @kpedro88