Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Add 2021 CMS Geometry Scenario #27646

Merged
merged 6 commits into from Aug 2, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jul 30, 2019

PR description:

  • Define a complete 2021 scenario and make it a default one
  • Make sure all materials are defined and are in a required order
    • the XML to DD4hep converter requires that a composite material refers to already defined materials
  • Replace a trackermaterial:T_Copper with an identical materials:Copper
  • Replace a trackermaterial:T_Alluminium with an identical materials:Alluminium
  • Add a cms::DDG4Builder to fill in the sensitive detector catalog
  • Print the sensitive detector catalog

@cvuosalo and @vargasa - FYI

 cmsRun SimG4Core/DD4hepGeometry/test/python/testZMM_13TeV_TuneCUETP8M1_cfi_GEN_SIM.py

will run and create a G4 geometry, the G4 production cuts and the sensitive dets catalog, but it will fail on finding an overlap:

Geant4Converter  INFO  +++  Successfully converted geometry to Geant4.

**************************************************** 
*  A runtime error has occured :                     
*    
-------- EEEE ------- G4Exception-START -------- EEEE -------
*** G4Exception : GeomMgt0002
      issued by : G4SmartVoxelHeader::BuildNodes()
PANIC! - Overlapping daughter with mother volume.
         Daughter physical volume tecmodule0r:TECModule0SideFrameLeft_1
         is entirely outside mother logical volume TECModule0 !!
-------- EEEE -------- G4Exception-END --------- EEEE -------

*  the program will have to be terminated - sorry.   
**************************************************** 

PR validation:

cmsRun DetectorDescription/DDCMS/test/python/testGeometry2021.py

if this PR is a backport please specify the original PR:

Before submitting your pull requests, make sure you followed this checklist:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

1 similar comment
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27646/11177

  • This PR adds an extra 84KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

Configuration/Geometry
DetectorDescription/DDCMS
Geometry/CMSCommonData
Geometry/ForwardCommonData
Geometry/MuonCommonData
Geometry/TrackerCommonData
SimG4Core/DD4hepGeometry
SimG4Core/Geometry

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @VinInn, @Martin-Grunewald, @ptcox, @ebrondol, @ghugo83, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ianna
Copy link
Contributor Author

ianna commented Jul 31, 2019

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-27646/11187

  • This PR adds an extra 84KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 31, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/1731/console Started: 2019/07/31 09:15

@cmsbuild
Copy link
Contributor

Pull request #27646 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

-1

Tested at: 71d8c72

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c143e/1731/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test DD4hepGeometryTestDriver had ERRORS

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Pull request #27646 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@ianna
Copy link
Contributor Author

ianna commented Jul 31, 2019

+1

@ianna
Copy link
Contributor Author

ianna commented Jul 31, 2019

urgent

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6c143e/1742/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-6c143e/22034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2026D46_GenSimHLBeamSpotFull14+DigiFullTrigger_2026D46+RecoFullGlobal_2026D46+HARVESTFullGlobal_2026D46

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2484130
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2483811
  • DQMHistoTests: Total skipped: 317
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 132 log files, 14 edm output root files, 32 DQM output files

@kpedro88
Copy link
Contributor

+upgrade

@ianna
Copy link
Contributor Author

ianna commented Aug 2, 2019

@civanch - please review

@civanch
Copy link
Contributor

civanch commented Aug 2, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 2, 2019

+1

@cmsbuild cmsbuild merged commit 0151b74 into cms-sw:master Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants