Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoAODv6 updates [106X] #28182

Merged
merged 36 commits into from Oct 28, 2019
Merged

NanoAODv6 updates [106X] #28182

merged 36 commits into from Oct 28, 2019

Conversation

peruzzim
Copy link
Contributor

backport #28122

PR description:
This pull request is the backport to 10_6_X of the updates for the NanoAODv6 campaign.
It's a cumulative backport of #28103 and #28122.
Depends on #28094 and #28136.

PR validation:
Usual validation in the cms-nanoAOD integration repository.

peruzzim and others added 30 commits August 22, 2019 16:08
@peruzzim
Merge pull request #391 from cms-nanoAOD/branch_10_6_2
ce46ada 
Update master-106X to CMSSW_10_6_2
@peruzzim
Merge pull request #403 from cms-nanoAOD/branch_10_6_4_patch1
7aa43f6 
Update master-106X to CMSSW_10_6_4_patch1
@IzaakWN @peruzzim
remove trigger object redundancy of OverlapFilterIsoEle bits 8 and 64…
7e57109 
…, cfr. OverlapFilterIsoMu
@peruzzim
Fix vtx cosTheta formula (by @amartelli)
df572f0
@peruzzim
Add GenModel event strings to NanoAOD
ff504c3
@peruzzim
Allow for samples without GenLumiInfoHeader product
00db1c8
@dmajumder @peruzzim
Adding mass-nondecorrelated DeepDoubleX taggers; renaming the mass-de…
96ad4cc 
…correlated DeepDoubleX taggers to make it explicit
@dmajumder @peruzzim
renaming DeepDoubleX taggers (restoring names of mass-decorrelated ta…
c1ec278 
…ggers and new explicit names for non-mass-decoreelated taggers)
@dmajumder @peruzzim
changing names of MD btagDDX taggers
a2376b3
@peruzzim
Fix ordering in nanoDQM_cfi.py
88e8de0
@peruzzim
Merge pull request #405 from cms-nanoAOD/port_1oct19_106X
6bb456c 
Port recent pull requests to 106X
@peruzzim
Add run2_nanoAOD_106Xv1 modifier
3df97f9
@peruzzim
Activate deepTauV2p1
fe03a52
@peruzzim
Fix ID name
6a30e98
@peruzzim
Fix logic of era modifiers
1fb8ee6
@peruzzim
Also treat run2_miniAOD_devel
f951302
@peruzzim
Merge pull request #408 from cms-nanoAOD/port_1oct19_106X
ce9f9fa 
Activate deepTau in 106X
@gouskos @peruzzim
add sv vars and relax dlensig preselection to 1 sigma
91e94f7
@gouskos @peruzzim
update nanoDQM_cfi
1ad1adc
@peruzzim
Roll back to previous SV preselection
101b04a
@sethcooper @peruzzim
add heep bitmask
a1f3b14
@sethcooper @peruzzim
updating nanoDQM_cfi consistently with vidNestedWPBitmap
70290d9
@peruzzim
Save mass of BSM genparticles
940c661
@arizzi @peruzzim
adding muon FSR recovery
589af7c
@peruzzim
adapt nanoAOD sequences to factorized FSR modules
eca077b
@peruzzim
Updated NanoAOD DQM configuration
22f494b
@peruzzim
Merge pull request #420 from cms-nanoAOD/pr_port106X_08oct19
915ee4f 
Port recent pull requests to 106X
@peruzzim
Merge remote-tracking branch 'cms-nanoAOD/master-106X' into pr_nanov6…
6a5d014 
…_106X
@peruzzim
Update jet ID to latest recommendations (WINTER17PUPPI, WINTER18, WIN…
fdbe7ca 
…TER18PUPPI)
@peruzzim
Merge pull request #425 from cms-nanoAOD/pr_nanov6_106X
fefe178 
Test PR NanoAODv6 106X
@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 24, 2019 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3128/console Started: 2019/10/24 14:07

@cmsbuild
Copy link
Contributor

+1
Tested at: d86d855
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7df35/3128/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b7df35/3128/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 103 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3212313
  • DQMHistoTests: Total failures: 93
  • DQMHistoTests: Total nulls: 3
  • DQMHistoTests: Total successes: 3211883
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.845 KiB( 32 files compared)
  • DQMHistoSizes: changed ( 1325.7 ): 1.845 KiB Physics/NanoAODDQM
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@peruzzim
Copy link
Contributor Author

+xpog

changes in NanoAOD products

@fabiocos
Copy link
Contributor

@peruzzim this PR is including also #28196 right?

@peruzzim
Copy link
Contributor Author

@peruzzim this PR is including also #28196 right?

Yes, it does.

@fabiocos
Copy link
Contributor

+operations

@fabiocos
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_0_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 4882131 into cms-sw:CMSSW_10_6_X Oct 28, 2019
@peruzzim peruzzim mentioned this pull request Oct 31, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-approved backport-ok comparison-available fully-signed operations-approved orp-approved tests-approved xpog-approved
Projects
None yet
Milestone
CMSSW_10_6_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@peruzzim @cmsbuild @santocch @fabiocos @IzaakWN @dmajumder @gouskos @sethcooper @arizzi