New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated 2018 Strips MC conditions to improve data/MC agreement #28234
Updated 2018 Strips MC conditions to improve data/MC agreement #28234
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28234/12379
|
A new Pull Request was created by @christopheralanwest for master. It involves the following packages: Configuration/AlCa @christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
@christopheralanwest thanks. Just a small comment: the update pertains only to 2018 whereas this is not clear from the PR title. |
please abort |
Jenkins tests are aborted. |
please test workflow 7.2,7.4 I forgot to test the 2018 cosmics GTs |
The tests are being triggered in jenkins. |
Comparison is ready Comparison Summary:
|
@christopheralanwest @tocheng @tlampen |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
hold @mmusich Should the Run-3 GTs use the three updated gain tags as well? |
Pull request has been put on hold by @christopheralanwest |
@christopheralanwest, please unhold it. |
unhold |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
This PR updates several SiStrip conditions in order to improve data/MC agreement [1]. It is the counterpart of commit e859edc of PR #28053. Note that commit e859edc uses an incorrect tag for SiStripNoisesRcd, which is corrected in this PR. PR #28053 will be updated accordingly.
GT diffs:
2018 pp collisions MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_v6/110X_upgrade2018_realistic_v7
2018 pp collisions MC with HE failure
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HEfail_v6/110X_upgrade2018_realistic_HEfail_v7
2018 cosmics with strips in deco mode
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018cosmics_realistic_deco_v3/110X_upgrade2018cosmics_realistic_deco_v4
2018 cosmics with strips in peak mode
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018cosmics_realistic_peak_v3/110X_upgrade2018cosmics_realistic_peak_v5
[1] https://indico.cern.ch/event/854616/#7-strip-mc-conditions-for-ul-2
PR validation:
See [1] for details. In addition, a technical test was performed:
runTheMatrix.py -l limited -i all --ibeos
[1] https://indico.cern.ch/event/854616/#7-strip-mc-conditions-for-ul-2
if this PR is a backport please specify the original PR:
This PR is not a backport. PR #28053 is a 10_6_X backport that contains these updates.