Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated 2018 Strips MC conditions to improve data/MC agreement #28234

Merged
merged 1 commit into from Oct 29, 2019

Conversation

christopheralanwest
Copy link
Contributor

PR description:

This PR updates several SiStrip conditions in order to improve data/MC agreement [1]. It is the counterpart of commit e859edc of PR #28053. Note that commit e859edc uses an incorrect tag for SiStripNoisesRcd, which is corrected in this PR. PR #28053 will be updated accordingly.

GT diffs:

2018 pp collisions MC
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_v6/110X_upgrade2018_realistic_v7
2018 pp collisions MC with HE failure
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018_realistic_HEfail_v6/110X_upgrade2018_realistic_HEfail_v7
2018 cosmics with strips in deco mode
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018cosmics_realistic_deco_v3/110X_upgrade2018cosmics_realistic_deco_v4
2018 cosmics with strips in peak mode
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/110X_upgrade2018cosmics_realistic_peak_v3/110X_upgrade2018cosmics_realistic_peak_v5

[1] https://indico.cern.ch/event/854616/#7-strip-mc-conditions-for-ul-2

PR validation:

See [1] for details. In addition, a technical test was performed: runTheMatrix.py -l limited -i all --ibeos

[1] https://indico.cern.ch/event/854616/#7-strip-mc-conditions-for-ul-2

if this PR is a backport please specify the original PR:

This PR is not a backport. PR #28053 is a 10_6_X backport that contains these updates.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28234/12379

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @christopheralanwest for master.

It involves the following packages:

Configuration/AlCa

@christopheralanwest, @tocheng, @cmsbuild, @franzoni, @tlampen, @pohsun can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@christopheralanwest
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3088/console Started: 2019/10/22 15:07

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@mmusich
Copy link
Contributor

mmusich commented Oct 22, 2019

@christopheralanwest thanks. Just a small comment: the update pertains only to 2018 whereas this is not clear from the PR title.

@christopheralanwest christopheralanwest changed the title Updated Strips conditions to improve data/MC agreement Updated 2018 Strips MC conditions to improve data/MC agreement Oct 22, 2019
@christopheralanwest
Copy link
Contributor Author

please abort

@cmsbuild
Copy link
Contributor

Jenkins tests are aborted.

@christopheralanwest
Copy link
Contributor Author

please test workflow 7.2,7.4

I forgot to test the 2018 cosmics GTs

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 22, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3097/console Started: 2019/10/22 17:27

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-329623/3097/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3316 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2961064
  • DQMHistoTests: Total failures: 4719
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2956003
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -4.018 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 7.3 ): -2.913 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181 ): -1.105 KiB SiStrip/MechanicalView
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@mmusich
Copy link
Contributor

mmusich commented Oct 29, 2019

@christopheralanwest @tocheng @tlampen
what is the plan for sign-off of this PR? I see that it already missed 11_0_0_pre11, while it would have been desirable to see the updates passed through at least one pre-release in master before deploying the conditions for Ultra-Legacy (despite the dedicated validation setup from PdmV).

@christopheralanwest
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@christopheralanwest
Copy link
Contributor Author

hold

@mmusich Should the Run-3 GTs use the three updated gain tags as well?

@cmsbuild
Copy link
Contributor

Pull request has been put on hold by @christopheralanwest
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

@mmusich
Copy link
Contributor

mmusich commented Oct 29, 2019

@christopheralanwest, please unhold it.
Run-3 should be indeed updated as well, but with different sets of noise extrapolations. We'll request the full update of the Run3 package later including updated Pixel and alignment.

@christopheralanwest
Copy link
Contributor Author

unhold

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants