Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ME0 trigger primitive producers from DIGI to L1 step #28329

Merged
merged 3 commits into from Nov 6, 2019
Merged

Move ME0 trigger primitive producers from DIGI to L1 step #28329

merged 3 commits into from Nov 6, 2019

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Nov 1, 2019

PR description:

Similar as PR #28254. To be integrated after #28183.

The ME0 pad producer has been moved to the L1T step. The ME0 pad cluster producer has been switched off, as ME0 pads will not be clustered in contrast to GE1/1 and GE2/1, according to the Phase-2 L1T design. I also enabled the ME0TriggerProducer in the L1T step in preparation for algorithm development in 2020.

PR validation:

I checked that it runs with WF 22034.0 in CMSSW_11_0_X_2019-10-31-1100

if this PR is a backport please specify the original PR:

N/A

@tahuang1991

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28329/12585

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1TMuon
L1Trigger/ME0Trigger
SimMuon/Configuration
SimMuon/GEMDigitizer

@benkrikler, @civanch, @kpedro88, @cmsbuild, @rekovic, @mdhildreth can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @battibass, @abbiendi, @Fedespring, @jshlee, @calderona, @HuguesBrun, @jhgoh, @thomreis, @cericeci, @trocino, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 1, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3304/console Started: 2019/11/01 17:44

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-85713d/3304/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2939026
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2938683
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 4, 2019

+upgrade

@fabiocos
Copy link
Contributor

fabiocos commented Nov 4, 2019

@rekovic @civanch could you please have a look?

@civanch
Copy link
Contributor

civanch commented Nov 4, 2019

+1

@rekovic
Copy link
Contributor

rekovic commented Nov 6, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@dildick
Copy link
Contributor Author

dildick commented Nov 6, 2019

Thanks!

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2019

+1

@cmsbuild cmsbuild merged commit e793655 into cms-sw:master Nov 6, 2019
@dildick dildick deleted the from-CMSSW_11_0_X_2019-10-31-1100-ME0-TP-Producers branch November 18, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants