Add LHEPtFilter plugin needed for MC generation

[ajgilbert]

PR description:

Adds a new plugin in GeneratorInterface/GenFilters that applies a user specified pT (or pT range) cut to the p4 sum of a subset of LHE-level particles. This is needed specifically for the production of Wgamma samples binned in the photon pT, but may be useful more generally in the future.

PR validation:

All tests in runTheMatrix.py -l limited -i all --ibeos passed.

if this PR is a backport please specify the original PR:

Not a backport.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12855

• This PR adds an extra 16KB to repository

• Found files with invalid states:

  • GeneratorInterface/GenFilters/interface/LHEPtFilter.h:
    • Added: fe520ee
    • Deleted: a27a382
  • GeneratorInterface/GenFilters/src/LHEPtFilter.cc:
    • Added: fe520ee
    • Deleted: a27a382

[cmsbuild]

A new Pull Request was created by @ajgilbert (Andrew Gilbert) for master.

It involves the following packages:

GeneratorInterface/GenFilters

@SiewYan, @efeyazgan, @mkirsano, @cmsbuild, @agrohsje, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[fabiocos]

@ajgilbert do you really need a separate header?

[cmsbuild]

The code-checks are being triggered in jenkins.

[ajgilbert]

@fabiocos Indeed not - have removed it.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12857

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • GeneratorInterface/GenFilters/interface/LHEPtFilter.h:
    • Added: fe520ee
    • Deleted: a27a382
  • GeneratorInterface/GenFilters/plugins/LHEPtFilter.h:
    • Added: a27a382
    • Deleted: 78c9206
  • GeneratorInterface/GenFilters/src/LHEPtFilter.cc:
    • Added: fe520ee
    • Deleted: a27a382

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-checks:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12857/code-checks.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12857/code-checks.patch | patch -p1
  You can also run scram build code-checks to apply code checks directly
• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12857/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12857/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12858

• This PR adds an extra 20KB to repository

• Found files with invalid states:

  • GeneratorInterface/GenFilters/interface/LHEPtFilter.h:
    • Added: fe520ee
    • Deleted: a27a382
  • GeneratorInterface/GenFilters/plugins/LHEPtFilter.h:
    • Added: a27a382
    • Deleted: 78c9206
  • GeneratorInterface/GenFilters/src/LHEPtFilter.cc:
    • Added: fe520ee
    • Deleted: a27a382

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12858/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28443/12858/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[fabiocos]

@ajgilbert @makortel does this need to be a global module? For what I can see it might work as a stream module, there is no global action implied, only event-by-event.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3758/console Started: 2019/12/03 16:10

[agrohsje]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[makortel]

@fabiocos

does this need to be a global module? For what I can see it might work as a stream module, there is no global action implied, only event-by-event.

"Global" is stricter category for modules than "stream" (must be immutable or thread safe). Framework creates one instance of a global module (wrt. an instance per stream for stream modules) leading to smaller memory consumption for immutable modules. Therefore it is preferable to use global modules where feasible.

[cmsbuild]

+1
Tested at: 2c2b6d8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f260/3758/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-47f260/3758/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2793840
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2793497
• DQMHistoTests: Total skipped: 341
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
• Checked 147 log files, 16 edm output root files, 34 DQM output files

[fabiocos]

@makortel thanks for the comment, global is stricter indeed, my comment was about the fact that was not strictly needed by the kind of operation performed in the code as it is. I agree that this implementation is more robust against a possible update that would require global operations.

[fabiocos]

+1