Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run3-hcx244 Switch of debug prints #28539

Merged
merged 1 commit into from Dec 5, 2019

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Dec 4, 2019

PR description:

Switch off debug prints

PR validation:

Standard tests performed

if this PR is a backport please specify the original PR:

It is strictly not back porting. But the debug prints will be off in the master thread as well

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

A new Pull Request was created by @bsunanda for CMSSW_11_0_X.

It involves the following packages:

Geometry/HcalCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 4, 2019

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3781/console Started: 2019/12/04 07:36

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d910ea/3781/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2793840
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2793498
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 4, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 4, 2019

This pull request is fully signed and it will be integrated in one of the next CMSSW_11_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

@bsunanda thank you, i consider this as a bug fix. Which is the PR implementing this in master?

@bsunanda
Copy link
Contributor Author

bsunanda commented Dec 5, 2019

@fabiocos I have removed the debug printing in #28506 - but that PR has many more things

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

@bsunanda thanks

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

bug-fix

@fabiocos
Copy link
Contributor

fabiocos commented Dec 5, 2019

+1

@cmsbuild cmsbuild merged commit 9d6f457 into cms-sw:CMSSW_11_0_X Dec 5, 2019
@cvuosalo
Copy link
Contributor

@fabiocos @bsunanda It looks like one of the files in this PR never made it into 11_1, and it was left out of #28506. But the problem is minor. Maybe Sunanda can fix it in his next PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants