Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pileup scenario for 2016 ultra legacy #28595

Merged
merged 1 commit into from Dec 11, 2019
Merged

Conversation

gkrintir
Copy link
Contributor

PR description:

This adds a pileup scenario for the 2016 ultra legacy (periods B-H), generated in the same way as the 2017 and 2018 UL scenaria #26572 and #27201 . The new scenario is named "2016_25ns_UltraLegacy_PoissonOOTPU".

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-28595/13105

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gkrintir (Georgios Konstantinos Krintiras) for master.

It involves the following packages:

Configuration/StandardSequences
SimGeneral/MixingModule

@civanch, @kpedro88, @cmsbuild, @franzoni, @mdhildreth, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 10, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/3910/console Started: 2019/12/10 16:35

@plujan
Copy link
Contributor

plujan commented Dec 10, 2019

For more details on this pileup scenario, you can see this talk here:
https://indico.cern.ch/event/870037/contributions/3670166/attachments/1960095/3257291/Pileup20191210.pdf

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-46fc84/3910/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2800084
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2799742
  • DQMHistoTests: Total skipped: 341
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@fabiocos
Copy link
Contributor

+operations

@fabiocos
Copy link
Contributor

@civanch comments?

@fabiocos
Copy link
Contributor

+1

@civanch
Copy link
Contributor

civanch commented Dec 11, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit e2813de into cms-sw:master Dec 11, 2019
@fabiocos
Copy link
Contributor

@gkrintir could you please provide the backport to 10_6_X?

@srimanob this is the bit you need for the additional 10_6_7_patch1, as far as I understand

@srimanob
Copy link
Contributor

srimanob commented Dec 11, 2019

@fabiocos @gkrintir
Yes, thanks very much. I assume we don't need this in 11_0.

@gkrintir
Copy link
Contributor Author

ok sure @fabiocos @srimanob i'm doing that

@srimanob
Copy link
Contributor

srimanob commented Apr 8, 2020

@gkrintir
The PU distribution seems strange (==2018), could you please check again?

Big thanks to TSG for reporting. @missirol @pgunnell @Sam-Harper @gennai @ameyer-cern

Here is the distribution I got from this PR
Screenshot 2020-04-08 17 44 06

From
https://indico.cern.ch/event/870037/contributions/3670166/attachments/1960095/3257291/Pileup20191210.pdf
The distribution of 2016 B-H should be
Screenshot 2020-04-08 17 55 12

FYI @silviodonato

@gkrintir
Copy link
Contributor Author

gkrintir commented Apr 8, 2020

Hi @srimanob all, very sorry for that, I am checking what happened here and fixing it.

Regards

@gkrintir
Copy link
Contributor Author

gkrintir commented Apr 8, 2020

Hi @srimanob @ameyer-cern

Fixed in #29431

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants