fixed bug in UL16 PU profile

[gkrintir]

PR description:

This fixes the pileup scenario for the 2016 ultra legacy (periods B-H), i.e.,

"2016_25ns_UltraLegacy_PoissonOOTPU"

from #28595 noted by @srimanob @ameyer-cern and reported by TSG et al: @missirol @pgunnell @Sam-Harper @gennai

In the validation plot below:

• black the pileup distribution from this PR

• red the pileup 'all 2016' distribution from this presentation that can be found here too

As for the bug, I had checked that the file didn't break the workflow:

/afs/cern.ch/user/g/gkrintir/public/ForPileup

but indeed it seems I didn't carefully investigate

/afs/cern.ch/user/g/gkrintir/public/ForPileup/histProbFunction.root

Regards and very sorry for that once more :(

[cmsbuild]

A new Pull Request was created by @gkrintir (Georgios Konstantinos Krintiras) for CMSSW_10_6_X.

It involves the following packages:

SimGeneral/MixingModule

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

• Backported from fixed bug in UL16 PU profile #29433

[srimanob]

@gkrintir
Thanks for a quick fix. Could you please prepare the master version also?

@silviodonato
This PR will be needed to reproduce the premixing library of Legacy-2016.

[gkrintir]

@srimanob

Done #29433

[civanch]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5619/console Started: 2020/04/09 09:52

[silviodonato]

urgent

[cmsbuild]

+1
Tested at: 2891f41
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12aeca/5619/summary.html
CMSSW: CMSSW_10_6_X_2020-04-08-2300
SCRAM_ARCH: slc7_amd64_gcc700

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-12aeca/5619/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3212324
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3211987
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_11_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

backport of #29433

[silviodonato]

+1