addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW #30015

amkalsi · 2020-05-28T13:27:37Z

PR description:

Changes made in code to introduce new MET filter

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

Before submitting your pull requests, make sure you followed this checklist:

verify that the PR is really intended for the chosen branch
verify that changes follow CMS Naming, Coding, And Style Rules
verify that the PR passes the basic test procedure suggested in the CMSSW PR instructions

cmsbuild · 2020-05-28T13:27:57Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-28T13:33:15Z

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30015/15707

This PR adds an extra 16KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMET/METFilters/plugins/BadParticleFilter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934

Code check has found code style and quality issues which could be resolved by applying following patch(s)

code-format:
https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30015/15707/code-format.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30015/15707/code-format.patch | patch -p1
You can also run scram build code-format to apply code format directly

slava77 · 2020-05-28T14:00:15Z

Changes made in code to introduce new MET filter

based on the current pre-clang-format changes, it seems that this PR is made from an old (10_6_X?) version of this code.
Please apply your edits directly on top of an 11_1_X version so that we do not have re-making of clang-formatting in the history.

Also, please use a more descriptive title for this PR

amkalsi · 2020-05-30T10:52:32Z

Hi @slava77 , I started from CMSSW_11_1_0_pre8 version and then added the modified files. Could you please let me know what is causing this?
About Code formatting, I ran scram build code-format command and can push the changes in repository

slava77 · 2020-05-30T12:53:14Z

Hi @slava77 , I started from CMSSW_11_1_0_pre8 version and then added the modified files. Could you please let me know what is causing this?

Thank you for clarifying.
Looking at 88b2430
it appears like your editor converts spaces to tabs, which all have to be reverted according to #30015 (comment)
Please check if you can disable it so that every next time you edit the file we don't get a two-step process of adding and removing the tabs

About Code formatting, I ran scram build code-format command and can push the changes in repository

To align with my earlier comment, it would be nice to squash the commits to .cc files into one commit.

slava77 · 2020-06-04T14:00:30Z

ping
@amkalsi please clarify on the status

cmsbuild · 2020-06-04T16:31:45Z

The code-checks are being triggered in jenkins.

amkalsi · 2020-06-04T16:33:15Z

Hi @slava77, I submitted the changes with correct format. Please check. Apologies for delay.. had some problems with charger of my laptop

cmsbuild · 2020-06-04T16:37:25Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30015/15873

This PR adds an extra 20KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoMET/METFilters/plugins/BadParticleFilter.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-make-unique #29934

cmsbuild · 2020-06-04T16:37:49Z

A new Pull Request was created by @amkalsi (Amandeep Kaur Kalsi) for master.

It involves the following packages:

RecoMET/METFilters

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @gouskos, @ahinzmann, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-06-04T16:41:07Z

@cmsbuild please test

slava77 · 2020-06-04T16:41:24Z

Also, please use a more descriptive title for this PR

slava77 · 2020-07-27T20:56:04Z

+1

for #30015 bb38311

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show differences only in TriggerResults variables corresponding to addition of a new filter path in the MET filter paths

silviodonato · 2020-07-28T19:24:02Z

merge

Dr15Jones · 2020-07-29T15:10:26Z

This appears to be causing failures in the IB for workflows 136.7722 and 1329.1 with the message

An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 283877 lumi: 11 event: 18022631 stream: 0
   [1] Running path 'nanoAOD_step'
   [2] Calling method for module BadParticleFilter/'BadPFMuonTagger'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for type: std::vector&lt;reco::Vertex&gt;
Looking for module label: offlinePrimaryVertices
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "SkipEvent = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

slava77 · 2020-07-29T15:27:40Z

@amkalsi
please take a look at the case with errors.
Please clarify if you can work on this today/tomorrow.
Thank you.

amkalsi · 2020-07-29T15:57:36Z

Hi @slava77, yes I will look into this. The error seems to be related to nanoAOD step. Could you please confirm? I am not sure how to reproduce this error as PR passed all the basic sets (*). Could you please let me know how did you get this error specifically running which step?
Also, we want to add this flag in nanoAOD samples also. I am trying to figure out how to do that.

(*)
runTheMatrix.py -l limited -i all --ibeos

slava77 · 2020-07-29T16:34:29Z

workflows 136.7722 and 1329.1 have problems
runTheMatrix.py -l 136.7722,1329.1 -i all --ibeos to reproduce

amkalsi · 2020-07-29T17:52:49Z

Hi @slava77, thanks I just made the required change in file : PhysicsTools/NanoAOD/python/extraflags_cff.py
It should work now.

slava77 · 2020-07-29T19:40:07Z

Hi @slava77, thanks I just made the required change in file : PhysicsTools/NanoAOD/python/extraflags_cff.py
It should work now.

I'm guessing that the change is in master...amkalsi:11_1_X-MET0filter
Please make a new PR with this.

thank you for the quick follow up.

amkalsi · 2020-07-30T03:00:33Z

done:
https://github.com/cms-sw/cmssw/pull/30974/files

slava77 · 2020-08-04T14:48:56Z

@amkalsi

from #30015 (comment)
I expect a backport of this for 10_6_X.
Please clarify the status of making the backport.
Thank you.

amkalsi · 2020-08-05T18:21:40Z

Hi @slava77 , I have started with CMSSW_10_6_3. Now running tests. I will make PR soon.

santocch · 2020-08-07T09:16:25Z

+1

cmsbuild · 2020-08-07T09:16:56Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

amkalsi added 2 commits May 28, 2020 15:24

new met filter

88b2430

new met filter

092e313

cmsbuild added this to the CMSSW_11_2_X milestone May 28, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels May 28, 2020

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 28, 2020

amkalsi mentioned this pull request May 30, 2020

New met filter #29996

Closed

Format changes

2a6aac2

cmsbuild added code-checks-pending and removed code-checks-rejected labels Jun 4, 2020

cmsbuild removed the code-checks-pending label Jun 4, 2020

cmsbuild added the code-checks-approved label Jun 4, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 24, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 27, 2020

silviodonato changed the title ~~addition of BadPFMuonFilter_Dz_cfi.py met filter in CMSSW~~ addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW Jul 28, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 28, 2020

cmsbuild merged commit 37a05c6 into cms-sw:master Jul 28, 2020

cmsbuild mentioned this pull request Jul 28, 2020

Remove redundant include. #30948

Merged

slava77 mentioned this pull request Jul 30, 2020

MET filter fix for nanoAOD step in extraflags_cff file i.e. addition of slimmedOfflinePrimaryVertices input tag (follow up of PR 30015) #30974

Merged

perrotta mentioned this pull request Aug 7, 2020

addition of new MET filter BadPFMuonDzFilter_cfi.py in CMSSW_10_6_X : i.e. backport from 11_1_X of PR 30015 and 30974 #31087

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Aug 7, 2020

amkalsi mentioned this pull request Sep 11, 2020

addition of BadPFMuonDzFilter plot in nanoDQM_cfi #31432

Merged

mariadalfonso mentioned this pull request Sep 14, 2020

features for V8 nanoAOD cms-nanoAOD/cmssw#533

Closed

55 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW #30015

addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW #30015

amkalsi commented May 28, 2020

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

slava77 commented May 28, 2020

amkalsi commented May 30, 2020 •

edited

slava77 commented May 30, 2020

slava77 commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

amkalsi commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

slava77 commented Jun 4, 2020

slava77 commented Jun 4, 2020

slava77 commented Jul 27, 2020

silviodonato commented Jul 28, 2020

Dr15Jones commented Jul 29, 2020

slava77 commented Jul 29, 2020

amkalsi commented Jul 29, 2020

slava77 commented Jul 29, 2020

amkalsi commented Jul 29, 2020

slava77 commented Jul 29, 2020

amkalsi commented Jul 30, 2020

slava77 commented Aug 4, 2020

amkalsi commented Aug 5, 2020

santocch commented Aug 7, 2020

cmsbuild commented Aug 7, 2020

addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW #30015

addition of BadPFMuonFilter_Dz_cfi.py MET filter in CMSSW #30015

Conversation

amkalsi commented May 28, 2020

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented May 28, 2020

cmsbuild commented May 28, 2020

slava77 commented May 28, 2020

amkalsi commented May 30, 2020 • edited

slava77 commented May 30, 2020

slava77 commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

amkalsi commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

cmsbuild commented Jun 4, 2020

slava77 commented Jun 4, 2020

slava77 commented Jun 4, 2020

slava77 commented Jul 27, 2020

silviodonato commented Jul 28, 2020

Dr15Jones commented Jul 29, 2020

slava77 commented Jul 29, 2020

amkalsi commented Jul 29, 2020

slava77 commented Jul 29, 2020

amkalsi commented Jul 29, 2020

slava77 commented Jul 29, 2020

amkalsi commented Jul 30, 2020

slava77 commented Aug 4, 2020

amkalsi commented Aug 5, 2020

santocch commented Aug 7, 2020

cmsbuild commented Aug 7, 2020

amkalsi commented May 30, 2020 •

edited