added esConsumes to modules in EventFilter/CSCRawToDigi

[JamminJones]

PR description:

added esConsumes to 3 modules

PR validation:

the code compiles

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30153/15938

• This PR adds an extra 32KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File EventFilter/CSCRawToDigi/plugins/CSCDCCUnpacker.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935
  • File EventFilter/CSCRawToDigi/plugins/CSCDigiValidator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

[cmsbuild]

A new Pull Request was created by @JamminJones for master.

It involves the following packages:

EventFilter/CSCRawToDigi

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @barvic this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6890/console Started: 2020/06/08 19:44

[Dr15Jones]

This change was done under my direction.

[cmsbuild]

+1
Tested at: 9f9af64
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a75ee/6890/summary.html
CMSSW: CMSSW_11_2_X_2020-06-08-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a75ee/6890/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2780497
• DQMHistoTests: Total failures: 47
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2780400
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

since the header files for files declaring plugins are not needed, this could be a good opportunity to merge them into the corresponding plugin implementation files.

This affects

• EventFilter/CSCRawToDigi/interface/CSCDCCUnpacker.h
• EventFilter/CSCRawToDigi/interface/CSCDigiValidator.h

[Dr15Jones]

@slava77 I’m working with a freshman undergrad with limited programming experience. As such, I was hoping to minimize the changes to the code to only be what was needed for the consumes migration.

[slava77]

@slava77 I’m working with a freshman undergrad with limited programming experience. As such, I was hoping to minimize the changes to the code to only be what was needed for the consumes migration.

if merging two files is too complicated, please at least move the headers to the /plugins directory

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30153/16034

• This PR adds an extra 36KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File EventFilter/CSCRawToDigi/plugins/CSCDCCUnpacker.cc modified in PR(s): Basic infrastructure for GEMs in CSC packer/unpacker #30167, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, Update accessor in CLCT and LCT data formats #30128
  • File EventFilter/CSCRawToDigi/plugins/CSCDigiToRawModule.cc modified in PR(s): Basic infrastructure for GEMs in CSC packer/unpacker #30167
  • File EventFilter/CSCRawToDigi/plugins/CSCDigiValidator.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937

[cmsbuild]

Pull request #30153 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/6962/console Started: 2020/06/11 16:54

[cmsbuild]

+1
Tested at: ad6fde6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a75ee/6962/summary.html
CMSSW: CMSSW_11_2_X_2020-06-11-1100
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2a75ee/6962/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 2779433
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2779382
• DQMHistoTests: Total skipped: 50
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 152 log files, 16 edm output root files, 36 DQM output files

[slava77]

+1

for #30153 ad6fde6

• code changes are in line with the PR title/description and the follow up review
• jenkins tests pass and comparisons with the baseline show no differences as expected

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1