New jet flavour definition update

[ferencek]

A follow-up to #2395. After consultations with the Generators and JetMET groups, this pull request expands the parton-based jet flavour to support several different hadronizers. It also includes minor improvements to the hadron-based jet flavour as well as general code cleanup and optimization.

[cmsbuild]

A new Pull Request was created by @ferencek (Dinko Ferencek) for CMSSW_7_1_X.

New jet flavour definition update

It involves the following packages:

PhysicsTools/JetExamples
PhysicsTools/JetMCAlgos
PhysicsTools/JetMCUtils
SimDataFormats/JetMatching

@civanch, @nclopezo, @mdhildreth, @monttj, @cmsbuild, @vadler, @Degano can you please review it and eventually sign? Thanks.
@pvmulder this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1
I found an error when building:

class edm::Refreco::JetFlavourInfoMatchingCollection,std::pair,edm::refhelper::FindUsingAdvancereco::JetFlavourInfoMatchingCollection,std::pair > >
class edm::AssociationVectoredm::RefToBaseProd
class edm::RefVectorreco::JetMatchedPartonsCollection,std::pair,edm::refhelper::FindUsingAdvancereco::JetMatchedPartonsCollection,std::pair > >
>> Compiling edm plugin /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-25-1400/src/PhysicsTools/JetMCAlgos/plugins/TauGenJetProducer.cc 
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-25-1400/src/PhysicsTools/JetMCAlgos/plugins/JetFlavourClustering.cc: In member function 'virtual void JetFlavourClustering::produce(edm::Event&, const edm::EventSetup&)':
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-25-1400/src/PhysicsTools/JetMCAlgos/plugins/JetFlavourClustering.cc:275:24: error: 'leptons_' was not declared in this scope
      iEvent.getByLabel(leptons_, leptons);
                        ^
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-03-25-1400/src/PhysicsTools/JetMCAlgos/src/BasePartonSelector.cc 
gmake: **\* [tmp/slc6_amd64_gcc481/src/PhysicsTools/JetMCAlgos/plugins/PhysicsToolsJetMCAlgosPlugins/JetFlavourClustering.o] Error 1
gmake: **\* Waiting for unfinished jobs....


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3025/671/summary.html

[ferencek]

Leftover getByLabel now replaced by getByToken and undeclared variable fixed.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3025/693/summary.html

[civanch]

+1

[vadler]

This is not the correct way of updating class version.
Please restore the ol version 10 and add a version 11 with the new checksum.

[ferencek]

Given that this is the first release in which this class is being introduced and therefore has never been stored in any output file, is it really needed to keep a class version for an intermediate version available only in a few pre-releases?

[vadler]

Since this code line falls under SIM responsibility and has been signed off already, it is not a show-stopper for AT.

[vadler]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?