Clang tidy checks - add new checks to .clang-tidy

[mrodozov]

PR description:

Adds the new checks to be applied on every PR.
To be merged after #30632

PR validation:

Applied on cmssw, with few exceptions (that are fixed) it builds

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30665/16949

• This PR adds an extra 12KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File .clang-tidy modified in PR(s): [TEST ONLY][Do not merge] New clang tidy checks #30508, Enable additional code checks #29858, [RFC] Test clang-tidy --checks performance-inefficient-algorithm #29929, [RFC] Test clang-tidy --checks performance-implicit-conversion-in-loop #29928, [RFC] Test clang-tidy --checks performance-for-range-copy #29927, [RFC] Test clang-tidy --checks performance-move-const-arg #29931, [RFC] Test clang-tidy --checks performance-unnecessary-value-param #29933, [RFC] Test clang-tidy --checks modernize-make-unique #29934, [RFC] Test clang-tidy --checks modernize-loop-convert #29935, [RFC] Test clang-tidy --checks modernize-use-auto #29936, [RFC] Test clang-tidy --checks modernize-use-emplace #29937, [RFC] Test clang-tidy --checks performance-inefficient-vector-operation #29930, [RFC] Test clang-tidy --checks performance-faster-string-find #29926

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

.clang-tidy

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

[makortel]

Was it this PR #30505 after which we agreed to enable the new checks?

[smuzaffar]

yes @makortel , we will wait for #30505 to be merged and then integrated new checks

[silviodonato]

Hi @smuzaffar , @makortel, @mrodozov , #30505 needs to be updated (there is a conflict to be solved). Can we merge this PR ?

[mrodozov]

@silviodonato In short, yes I'm in favor to merge it, tldr:
I checked #30505 last week and it needed rebase. Since it needs rebase and it's only 8 files running the code checks on it when rebasing doesn't look like a big issue to me, but there might be other concerns.

[silviodonato]

@smuzaffar , @makortel we agreed to merge this PR, didn't we?

[smuzaffar]

+core
yes

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-08-03-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/8557/console Started: 2020/08/04 16:46

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[silviodonato]

+1

[cmsbuild]

+1
Tested at: b0fa704
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-918850/8557/summary.html
CMSSW: CMSSW_11_2_X_2020-08-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-918850/8557/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 34
• DQMHistoTests: Total histograms compared: 2525448
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2525395
• DQMHistoTests: Total skipped: 47
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.004 KiB( 33 files compared)
• DQMHistoSizes: changed ( 10224.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 144 log files, 17 edm output root files, 34 DQM output files