MF regression IB tests #31651

namapane · 2020-10-02T14:08:12Z

PR description:

Add standard MF regression tests as IB tests. Both DDD and DD4hep versions of the MF geometry builder are tested.

Also, cleanup 2 obsolete MF standard sequences that have been deprecated since ages and are no longer referenced anywhere.

PR validation:

Tested that the tests succeed in normal conditions and that regression failures are reported.

cmsbuild · 2020-10-02T14:08:34Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-02T14:13:30Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31651/18750

This PR adds an extra 20KB to repository

cmsbuild · 2020-10-02T14:13:55Z

A new Pull Request was created by @namapane (Nicola Amapane) for master.

It involves the following packages:

Configuration/StandardSequences
MagneticField/Engine

@perrotta, @silviodonato, @cmsbuild, @franzoni, @slava77, @jpata, @qliphy, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @lecriste, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-03T01:23:56Z

@cmsbuild please test

cmsbuild · 2020-10-03T01:24:20Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-02-2300/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9716/console Started: 2020/10/03 07:11

cmsbuild · 2020-10-03T06:14:26Z

-1

Tested at: fe8e526

CMSSW: CMSSW_11_2_X_2020-10-02-2300
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55171b/9716/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following workflows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step2

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step2_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step2

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step2_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

136.793 step2

runTheMatrix-results/136.793_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017/step2_RunDoubleEG2017C+RunDoubleEG2017C+HLTDR2_2017+RECODR2_2017reHLT_skimDoubleEG_Prompt+HARVEST2017.log

136.8311 step2

runTheMatrix-results/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017/step2_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017.log

136.874 step2

runTheMatrix-results/136.874_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM/step2_RunEGamma2018C+RunEGamma2018C+HLTDR2_2018+RECODR2_2018reHLT_skimEGamma_Offline_L1TEgDQM+HARVEST2018_L1TEgDQM.log

136.88811 step2

runTheMatrix-results/136.88811_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL/step2_RunJetHT2018D_reminiaodUL+RunJetHT2018D_reminiaodUL+REMINIAOD_data2018UL+HARVEST2018_REMINIAOD_data2018UL.log

140.56 step2

runTheMatrix-results/140.56_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18/step2_RunHI2018+RunHI2018+RECOHID18+HARVESTDHI18.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVDSIPIXELCALRUN1+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake2 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_2016 --fileout file:RelVal_Raw_Fake2_DATA.root --filein /store/data/Run2016B/JetHT/RAW/v1/000/272/762/00000/C666CDE2-E013-E611-B15A-02163E011DBE.root : FAILED - time: date Sat Oct 3 07:59:28 2020-date Sat Oct 3 07:59:20 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake2.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 07:59:28 2020-date Sat Oct 3 07:59:20 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 07:59:28 2020-date Sat Oct 3 07:59:20 2020 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_PRef --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --eventcontent RAW --fileout file:RelVal_Raw_PRef_DATA.root --filein /store/data/Run2018D/EphemeralHLTPhysics1/RAW/v1/000/323/775/00000/2E066536-5CF2-B340-A73B-209640F29FF6.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task())' : FAILED - time: date Sat Oct 3 07:59:35 2020-date Sat Oct 3 07:59:25 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PRef.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 07:59:35 2020-date Sat Oct 3 07:59:25 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 07:59:35 2020-date Sat Oct 3 07:59:25 2020 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_HIon --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3_pp_on_PbPb --fileout file:RelVal_Raw_HIon_DATA.root --filein /store/data/Run2018D/HIMinimumBias0/RAW/v1/000/325/112/00000/660F62BB-9932-D645-A4A4-0BBBDA3963E8.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task()); from FWCore.ParameterSet.MassReplace import massSearchReplaceAnyInputTag; massSearchReplaceAnyInputTag(process.SimL1Emulator,"rawDataCollector","rawDataRepacker",False,True)' : FAILED - time: date Sat Oct 3 07:59:42 2020-date Sat Oct 3 07:59:28 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_HIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 07:59:42 2020-date Sat Oct 3 07:59:28 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:HIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_HIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3_pp_on_PbPb --processName=HLTRECO --filein file:RelVal_Raw_HIon_DATA.root --fileout file:RelVal_Raw_HIon_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 07:59:42 2020-date Sat Oct 3 07:59:28 2020 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_PIon --relval 9000,50 --datatier "RAW" --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --eventcontent RAW --fileout file:RelVal_Raw_PIon_DATA.root --filein /store/data/Run2018D/EphemeralHLTPhysics1/RAW/v1/000/323/775/00000/2E066536-5CF2-B340-A73B-209640F29FF6.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task())' : FAILED - time: date Sat Oct 3 07:59:51 2020-date Sat Oct 3 07:59:40 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_PIon.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 07:59:51 2020-date Sat Oct 3 07:59:40 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 07:59:51 2020-date Sat Oct 3 07:59:40 2020 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:GT1 --data --scenario=pp -n 10 --conditions auto:run1_hlt_Fake --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --fileout file:RelVal_Raw_Fake_DATA.root --filein /store/data/Run2012A/MuEG/RAW/v1/000/191/718/14932935-E289-E111-830C-5404A6388697.root : FAILED - time: date Sat Oct 3 08:00:07 2020-date Sat Oct 3 07:59:54 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 08:00:07 2020-date Sat Oct 3 07:59:54 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 08:00:07 2020-date Sat Oct 3 07:59:54 2020 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:Full --data --scenario=pp -n 10 --conditions auto:run3_hlt_GRun --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run3 --fileout file:RelVal_Raw_GRun_DATA.root --filein /store/data/Run2018D/EphemeralHLTPhysics1/RAW/v1/000/323/775/00000/2E066536-5CF2-B340-A73B-209640F29FF6.root --customise_commands='if hasattr(process,"simMuonGEMPadTask"): setattr(process,"simMuonGEMPadTask",cms.Task())' : FAILED - time: date Sat Oct 3 08:00:20 2020-date Sat Oct 3 07:59:57 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 08:00:20 2020-date Sat Oct 3 07:59:57 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 08:00:20 2020-date Sat Oct 3 07:59:57 2020 s - exit: 256
cmsDriver.py RelVal -s L1REPACK:GCTGT --data --scenario=pp -n 10 --conditions auto:run2_hlt_Fake1 --relval 9000,50 --datatier "RAW" --eventcontent RAW --customise=HLTrigger/Configuration/CustomConfigs.L1T --era Run2_25ns --fileout file:RelVal_Raw_Fake1_DATA.root --filein /store/data/Run2015D/MuonEG/RAW/v1/000/256/677/00000/80950A90-745D-E511-92FD-02163E011C5D.root : FAILED - time: date Sat Oct 3 08:00:10 2020-date Sat Oct 3 07:59:59 2020 s - exit: 256
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw-patch/CMSSW_11_2_X_2020-10-02-2300/src/HLTrigger/Configuration/test/OnLine_HLT_Fake1.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Sat Oct 3 08:00:10 2020-date Sat Oct 3 07:59:59 2020 s - exit: 21504
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Sat Oct 3 08:00:10 2020-date Sat Oct 3 07:59:59 2020 s - exit: 256

cmsbuild · 2020-10-03T06:14:29Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

namapane · 2020-10-03T06:52:06Z

So the 2 deprecated configurations I intended to cleanup are actually still relied on - I clearly overlooked this.
I'm putting these back and will target the cleanup elsewhere.
In the meanwhile, should I add a deprecation message to MagneticField_AutoFromDBCurrent_cff.py, which is the one used in the tests (!), like the one that is already present in MagneticField_38T_PostLS1_cff.py?

These are, unfortunately, still in use. Will target them in a future PR.

cmsbuild · 2020-10-03T07:08:38Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31651/18765

This PR adds an extra 8KB to repository
Found files with invalid states:
- Configuration/StandardSequences/python/MagneticField_38T_PostLS1_cff.py:
  - Deleted: 825e3ac
  - Added: 9c4fad1
- Configuration/StandardSequences/python/MagneticField_AutoFromDBCurrent_cff.py:
  - Deleted: 825e3ac
  - Added: 9c4fad1

cmsbuild · 2020-10-03T07:09:00Z

Pull request #31651 was updated. @perrotta, @jpata, @cmsbuild, @slava77 can you please check and sign again.

perrotta · 2020-10-03T07:27:51Z

Configuration/StandardSequences/python/MagneticField_38T_PostLS1_cff.py

@@ -0,0 +1,13 @@
+### THIS CFF IS DEPRECATED!!!! ###
+# please use MagneticField_cff.py instead


In the comment fields you suggest to replace this with MagneticField_cff, while in the command line you substitute it with MagneticField_38T_cff: please fix the one which is wrong.

It really depends what users intended to get when they picked this cff.
The name suggests a fixed 3.8T map regardless of conditions, so MagneticField_38T_cff would be the verbatim replacement. This is why it is substituted with MagneticField_38T_cff in the command.
But most likely it has been picked because it looked like the right one at the time: I expect that in 99% of the cases the standard MagneticField_cff would be the right choice instead. Which is why users are recommended to use the latter instead. Usage of non-conditions-dependent configs should in fact be discouraged for general usage.

BTW (although it's probably clear) I am just reverting here these files as they were before,

Eventually going through all instances and fixing them one by one with the correct cff will be the right choice, see comment below.

perrotta · 2020-10-03T07:31:44Z

So the 2 deprecated configurations I intended to cleanup are actually still relied on - I clearly overlooked this.
I'm putting these back and will target the cleanup elsewhere.
In the meanwhile, should I add a deprecation message to MagneticField_AutoFromDBCurrent_cff.py, which is the one used in the tests (!), like the one that is already present in MagneticField_38T_PostLS1_cff.py?

@namapane These two deprecated configs appear to be included in a few tests. One should eventually remove the two configs, and replace them with the correct one in all those tests. This can be longish, but easy to do: maybe it could be applied already once for all in this PR.

namapane · 2020-10-03T09:08:21Z

Yeah I intend to replace them anywhere they appear, which deservers another PR. I just made a mistake here in searching it in dxr, and concluded it was no longer used, so safe to be bundled with other stuff...

perrotta · 2020-10-05T15:12:52Z

please test

cmsbuild · 2020-10-05T15:13:13Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-05-1200/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9733/console Started: 2020/10/05 17:13

cmsbuild · 2020-10-05T16:38:17Z

+1
Tested at: 9c4fad1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55171b/9733/summary.html
CMSSW: CMSSW_11_2_X_2020-10-05-1200
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-10-05T16:38:19Z

Comparison job queued.

cmsbuild · 2020-10-05T18:09:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-55171b/9733/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2542225
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2542196
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 149 log files, 22 edm output root files, 35 DQM output files

perrotta · 2020-10-05T20:30:38Z

+1

Unit test outputs are there, as intended for this PR

cmsbuild · 2020-10-05T20:31:18Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-10-06T01:27:18Z

+1

namapane added 2 commits October 2, 2020 15:55

cleanup obsolete, unused standard sequences

825e3ac

Add IB tests for MagneticField

fe8e526

cmsbuild added this to the CMSSW_11_2_X milestone Oct 2, 2020

cmsbuild added code-checks-pending comparison-pending operations-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 2, 2020

namapane changed the title ~~Mf regression ib~~ MF regression IB tests Oct 2, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 2, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 3, 2020

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 3, 2020

Revert "cleanup obsolete, unused standard sequences".

9c4fad1

These are, unfortunately, still in use. Will target them in a future PR.

cmsbuild removed code-checks-approved comparison-notrun labels Oct 3, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 3, 2020

perrotta reviewed Oct 3, 2020

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Oct 5, 2020

cmsbuild added tests-approved and removed tests-started labels Oct 5, 2020

cmsbuild added comparison-available and removed comparison-pending labels Oct 5, 2020

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Oct 5, 2020

cmsbuild added orp-approved and removed orp-pending labels Oct 6, 2020

cmsbuild merged commit 4b7b712 into cms-sw:master Oct 6, 2020

mmusich mentioned this pull request Oct 14, 2020

move from MagneticField_AutoFromDBCurrent_cff to MagneticField in all Tracker-related configurations #31788

Merged

namapane mentioned this pull request Oct 15, 2020

MF standard sequences cleanup #31809

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MF regression IB tests #31651

MF regression IB tests #31651

namapane commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

slava77 commented Oct 3, 2020

cmsbuild commented Oct 3, 2020 •

edited

cmsbuild commented Oct 3, 2020

cmsbuild commented Oct 3, 2020

namapane commented Oct 3, 2020

cmsbuild commented Oct 3, 2020

cmsbuild commented Oct 3, 2020

perrotta Oct 3, 2020

namapane Oct 3, 2020

perrotta commented Oct 3, 2020

namapane commented Oct 3, 2020

perrotta commented Oct 5, 2020

cmsbuild commented Oct 5, 2020 •

edited

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

perrotta commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

qliphy commented Oct 6, 2020

		@@ -0,0 +1,13 @@
		### THIS CFF IS DEPRECATED!!!! ###
		# please use MagneticField_cff.py instead

MF regression IB tests #31651

MF regression IB tests #31651

Conversation

namapane commented Oct 2, 2020

PR description:

PR validation:

cmsbuild commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

cmsbuild commented Oct 2, 2020

slava77 commented Oct 3, 2020

cmsbuild commented Oct 3, 2020 • edited

cmsbuild commented Oct 3, 2020

cmsbuild commented Oct 3, 2020

namapane commented Oct 3, 2020

cmsbuild commented Oct 3, 2020

cmsbuild commented Oct 3, 2020

perrotta Oct 3, 2020

Choose a reason for hiding this comment

namapane Oct 3, 2020

Choose a reason for hiding this comment

perrotta commented Oct 3, 2020

namapane commented Oct 3, 2020

perrotta commented Oct 5, 2020

cmsbuild commented Oct 5, 2020 • edited

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

perrotta commented Oct 5, 2020

cmsbuild commented Oct 5, 2020

qliphy commented Oct 6, 2020

cmsbuild commented Oct 3, 2020 •

edited

cmsbuild commented Oct 5, 2020 •

edited