Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

Merged

Commits on Oct 10, 2020

  1. Changed DeepTau modules so that they can use AOD and RECO input

    - input tokens for candidates and taus now use base classes
    - taus and candidates accessed by dynamic_cast and edm::View
    - is_online boolean in fillDescriptions
    - Electron and muon collections empty if is_online
    - Changed some quantities with functions that calculate quantity differently depending on the input
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    eb2510e View commit details
    Browse the repository at this point in the history
  2. Update DeepTauId.cc

    Removed 2 leftover comments
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    55ff8ad View commit details
    Browse the repository at this point in the history
  3. Added customization file used for testing module at RECO level

    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    94cfe61 View commit details
    Browse the repository at this point in the history
  4. - Clean up whitespaces, empty lines and unneeded lines

    - Ran "scram build code-checks" and "scram build code-format"
    - Implemented the new container format. For now the indices of the discriminators are given as inputs in the config file. I will look into using provenance
    - Switched order of the if statements (for is_online and version checks) in the getPredictions function
    - turned tau_index to const
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    28d8204 View commit details
    Browse the repository at this point in the history
  5. Changed type of electron_collection and muon_collection in lightLepFu…

    …nc to edm::Handle instead of the vector. The way it was before worked in pre3 but switching to pre5 broke that.
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    393e750 View commit details
    Browse the repository at this point in the history
  6. - Implement Prediscriminators

    - Change TauRefType to edm::RefToBase<reco::BaseTau>
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    37c61b1 View commit details
    Browse the repository at this point in the history
  7. Switch discriminator indices for RECO from configuration input to mat…

    …ching from provenance.
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    03c4aee View commit details
    Browse the repository at this point in the history
  8. Translated map with indices for the basic discriminators to enum

    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    729370c View commit details
    Browse the repository at this point in the history
  9. Cleanup of leftover lines from testing

    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    5e13647 View commit details
    Browse the repository at this point in the history
  10. Made stringFromDiscriminator map and the vectors defining required di…

    …scriminators into static const
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    b6c8594 View commit details
    Browse the repository at this point in the history
  11. Once again forgot to remove a print line from testing

    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    e281eab View commit details
    Browse the repository at this point in the history
  12. - Changed some member names to be according to the naming conventions

    - Added, removed and changed some option for the basicDiscriminators in the deepTauAtHLT.py config file to be more in line with RecoTauTag/Configuration/HPSPFTaus_cff.py
    lwezenbe authored and Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    c8c8580 View commit details
    Browse the repository at this point in the history
  13. apply code formatting

    Sebastian Wozniewski committed Oct 10, 2020
    Copy the full SHA
    a672dac View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2020

  1. remove redundant const qualifiers

    Sebastian Wozniewski committed Oct 11, 2020
    Copy the full SHA
    235817b View commit details
    Browse the repository at this point in the history

Commits on Oct 12, 2020

  1. move deepTauAtHLT.py to RecoTauTag/HLTProducers

    Sebastian Wozniewski committed Oct 12, 2020
    Copy the full SHA
    2ad85f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2020

  1. Make changes requested in PR cms-sw#31744

    lwezenbe authored and swozniewski committed Oct 30, 2020
    Copy the full SHA
    f267646 View commit details
    Browse the repository at this point in the history
  2. fix code format

    Sebastian Wozniewski committed Oct 30, 2020
    Copy the full SHA
    a52d6e4 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    f14d756 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2020

  1. fix input pfCand_muon_dz_sig

    Sebastian Wozniewski committed Nov 10, 2020
    Copy the full SHA
    bc1db4a View commit details
    Browse the repository at this point in the history