Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

swozniewski · 2020-10-10T17:48:12Z

PR description:

Input tokens for Candidate and Tau collections now use base classes
taus and candidates are accessed by dynamic_cast and edm::View on the base class objects
A boolean "is_online" is added to specify whether the input is AOD or RECO
Electron and muon collections are initialized as empty arrays if is_online is True
A structure "tauFunc" containing a range of functions was added to calculate both tau ID quantities as well as other quantities that needed recalculation for RECO input.
A namespace "candFunc" was introduced containing functions to calculate quantities that need recalculation for RECO input.
A structure lightLepFunc was added to initialize the electron and muon collections depending on the value of the boolean "is_online"
Functions that use taus or candidates have been turned into template functions where the CandidateType and/or TauType are specified

PR validation:

code and format checks passed
unit tests passed
limited matrix tests passed
RecoTauTag/RecoTau/test/runDeepTauIDsOnMiniAOD.py was run with a setup without any changes and the version of the setup in this PR over the same 1000 events of the same dataset. The output of both runs was identical.
A simple setup was made with hltGetConfiguration for the latest HLT menu where the isolation modules were replaced by the adapted DeepTauId module. This setup ran smoothly and the output looked as expected.

- input tokens for candidates and taus now use base classes - taus and candidates accessed by dynamic_cast and edm::View - is_online boolean in fillDescriptions - Electron and muon collections empty if is_online - Changed some quantities with functions that calculate quantity differently depending on the input

Removed 2 leftover comments

- Ran "scram build code-checks" and "scram build code-format" - Implemented the new container format. For now the indices of the discriminators are given as inputs in the config file. I will look into using provenance - Switched order of the if statements (for is_online and version checks) in the getPredictions function - turned tau_index to const

…nc to edm::Handle instead of the vector. The way it was before worked in pre3 but switching to pre5 broke that.

- Change TauRefType to edm::RefToBase<reco::BaseTau>

…ching from provenance.

…scriminators into static const

- Added, removed and changed some option for the basicDiscriminators in the deepTauAtHLT.py config file to be more in line with RecoTauTag/Configuration/HPSPFTaus_cff.py

cmsbuild · 2020-10-10T17:48:36Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-10-10T17:54:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31744/18954

This PR adds an extra 212KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File RecoTauTag/RecoTau/python/tools/runTauIdMVA.py modified in PR(s): Add anti-electron tauID for phase2 #31470

cmsbuild · 2020-10-10T17:55:06Z

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

HLTrigger/Configuration
RecoTauTag/RecoTau

@perrotta, @Martin-Grunewald, @slava77, @cmsbuild, @fwyzard, @jpata can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @riga this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-10-10T18:28:53Z

@cmsbuild please test

cmsbuild · 2020-10-10T18:29:12Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-10-10-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/9854/console Started: 2020/10/10 20:31

cmsbuild · 2020-11-10T13:43:59Z

+1
Tested at: bc1db4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df7355/10607/summary.html
CMSSW: CMSSW_11_2_X_2020-11-09-2300
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-11-10T13:44:01Z

Comparison job queued.

cmsbuild · 2020-11-10T14:58:20Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-df7355/10607/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 35
DQMHistoTests: Total histograms compared: 2529296
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2529273
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
Checked 148 log files, 22 edm output root files, 35 DQM output files

slava77 · 2020-11-10T18:34:31Z

+1

for #31744 bc1db4a

code changes are in line with the PR description and the follow up review
jenkins tests pass and comparisons with the baseline show no differences

silviodonato · 2020-11-12T11:49:30Z

@cms-sw/hlt-l2 do you have any comments?

silviodonato · 2020-11-16T13:04:14Z

kind reminder @cms-sw/hlt-l2

Martin-Grunewald · 2020-11-17T13:38:01Z

+1

cmsbuild · 2020-11-17T13:38:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

qliphy · 2020-11-18T00:12:44Z

+1

lwezenbe and others added 13 commits October 10, 2020 10:23

Update DeepTauId.cc

55ff8ad

Removed 2 leftover comments

Added customization file used for testing module at RECO level

94cfe61

Changed type of electron_collection and muon_collection in lightLepFu…

393e750

…nc to edm::Handle instead of the vector. The way it was before worked in pre3 but switching to pre5 broke that.

- Implement Prediscriminators

37c61b1

- Change TauRefType to edm::RefToBase<reco::BaseTau>

Switch discriminator indices for RECO from configuration input to mat…

03c4aee

…ching from provenance.

Translated map with indices for the basic discriminators to enum

729370c

Cleanup of leftover lines from testing

5e13647

Made stringFromDiscriminator map and the vectors defining required di…

b6c8594

…scriminators into static const

Once again forgot to remove a print line from testing

e281eab

- Changed some member names to be according to the naming conventions

c8c8580

- Added, removed and changed some option for the basicDiscriminators in the deepTauAtHLT.py config file to be more in line with RecoTauTag/Configuration/HPSPFTaus_cff.py

apply code formatting

a672dac

cmsbuild added this to the CMSSW_11_2_X milestone Oct 10, 2020

cmsbuild added code-checks-pending comparison-pending hlt-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 10, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 10, 2020

cmsbuild added tests-started and removed tests-pending labels Oct 10, 2020

cmsbuild added the tests-started label Nov 10, 2020

cmsbuild added tests-approved and removed tests-started labels Nov 10, 2020

cmsbuild added comparison-available and removed comparison-pending labels Nov 10, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Nov 10, 2020

cmsbuild added fully-signed hlt-approved and removed hlt-pending pending-signatures labels Nov 17, 2020

cmsbuild added orp-approved and removed orp-pending labels Nov 18, 2020

cmsbuild merged commit 96acaf4 into cms-sw:master Nov 18, 2020

This was referenced Nov 18, 2020

Revert "Move CaloL1 online DQM to Global" #32173

Merged

MLPF: first integration of EDProducer and training code #32048

Merged

swozniewski mentioned this pull request Jan 18, 2021

Further preparations of deep tau ID for hlt phase2 #32676

Merged

swozniewski pushed a commit to cms-tau-pog/cmssw that referenced this pull request Jan 18, 2021

Make changes requested in PR cms-sw#31744

9a6c59d

swozniewski pushed a commit to cms-tau-pog/cmssw that referenced this pull request Jan 18, 2021

Make changes requested in PR cms-sw#31744 (#143)

66081f5

swozniewski mentioned this pull request Feb 5, 2021

Preparations of deep tau ID for hlt phase2 (backport to CMSSW_11_1_X) #32831

Merged

fwyzard mentioned this pull request May 11, 2021

Implement Phase2 HLT Taus and L1HPSTaus fwyzard/cmssw#16

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

swozniewski commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

slava77 commented Oct 10, 2020

cmsbuild commented Oct 10, 2020 •

edited

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

slava77 commented Nov 10, 2020

silviodonato commented Nov 12, 2020

silviodonato commented Nov 16, 2020

Martin-Grunewald commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

qliphy commented Nov 18, 2020

Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

Change DeepTauID modules so they can also process RECO input for HLT purposes #31744

Conversation

swozniewski commented Oct 10, 2020

PR description:

PR validation:

cmsbuild commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

cmsbuild commented Oct 10, 2020

slava77 commented Oct 10, 2020

cmsbuild commented Oct 10, 2020 • edited

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

cmsbuild commented Nov 10, 2020

slava77 commented Nov 10, 2020

silviodonato commented Nov 12, 2020

silviodonato commented Nov 16, 2020

Martin-Grunewald commented Nov 17, 2020

cmsbuild commented Nov 17, 2020

qliphy commented Nov 18, 2020

cmsbuild commented Oct 10, 2020 •

edited