Added LogFwk* logging levels to be used by the framework

[Dr15Jones]

PR description:

• Added LogFwkInfo and LogFwkVerbatim with new level FWKINFO
• Refactored internals of MessageLogger to make it easier to maintain

This should make it easier to set a theshold such that INFO messages are ignored but the framework status messages are still kept.

PR validation:

Code compiles and framework unit tests pass.

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

NOTE: I decided to wait for another pull request to actually use the new threshold as many non-framework configurations are dependent upon how the default MessageLogger config is structured right now.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31815/19117

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File FWCore/Framework/src/InputSource.cc modified in PR(s): use standard libuuid functions, add binary uuid option #31658
  • File FWCore/Framework/src/Schedule.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
  • File FWCore/MessageLogger/interface/MessageLogger.h modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629
  • File FWCore/MessageLogger/interface/MessageSender.h modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629
  • File FWCore/MessageService/src/MessageLogger.cc modified in PR(s): Delete unscheduled modules that are not consumed by any scheduled module #29553
  • File FWCore/MessageService/test/unit_test_outputs/infos.log modified in PR(s): Add support of printf()-like formatting to MessageLogger #30629

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FWCore/Framework
FWCore/MessageLogger
FWCore/MessageService
FWCore/Modules

@makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @wddgit this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.

• CMSSW_11_2_X_2020-10-15-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/10002/console Started: 2020/10/16 05:56

[cmsbuild]

-1

Tested at: 09216a8

CMSSW: CMSSW_11_2_X_2020-10-15-1100
SCRAM_ARCH: slc7_amd64_gcc820
You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94af9a/10002/summary.html

I found follow errors while testing this PR

Failed tests: Build HeaderConsistency

• Build:

I found compilation error when building:

>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtHadEvtSolution.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtGenEvent.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtSemiLepEvtPartons.cc
>> Compiling  /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtSemiEvtSolution.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtEvent.cc:3:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/FWCore/MessageLogger/interface/MessageLogger.h:124:42: error: conflicting declaration 'using LogInfo = class edm::Log'
   using LogInfo = Log;
                                          ^
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/src/TtEvent.cc:1:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_11_2_X_2020-10-15-1100/src/AnalysisDataFormats/TopObjects/interface/TtEvent.h:24:9: note: previous declaration as 'class edm::LogInfo'
   class LogInfo;


[cmsbuild]

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-94af9a/10034/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2543752
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2543726
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 149 log files, 22 edm output root files, 35 DQM output files

[santocch]

+1

[makortel]

+1

[Dr15Jones]

@cms-sw/upgrade-l2 it would be great if you could sign this

[kpedro88]

+upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1