Update nano modifiers

[mariadalfonso]

preparation for nanoV9 post reminiUL

• add new modifier nanoAOD_106Xv2
• add wf for data 136.8523
• cleanup the repetition in using modifier
• those nanoAOD_106Xv1 and nanoAOD_106Xv2 added in the runTheMatrix to run by default in the "please test"

TO DO:

• add MC wf (pending this Update nano modifiers  #32463 (comment))

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32463/20367

• This PR adds an extra 96KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - Pixel workflows (12/N) #31854
  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz #32103
  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): PPS nanoAOD #31531, Refactoring gen weight storage in EDM + Nano integration #32167
  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

[cmsbuild]

A new Pull Request was created by @mariadalfonso for master.

It involves the following packages:

Configuration/Eras
Configuration/PyReleaseValidation
Configuration/StandardSequences
PhysicsTools/NanoAOD

@gouskos, @jordan-martins, @chayanit, @wajidalikhan, @kpedro88, @cmsbuild, @silviodonato, @franzoni, @fgolf, @qliphy, @mariadalfonso, @santocch, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @swertz, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @slomeo, @lecriste, @gpetruc, @mtosi, @peruzzim, @dgulhan this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[mariadalfonso]

please test workflow 136.8523

[cmsbuild]

-1

Failed Tests: Python3
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-341cb0/11583/summary.html
CMSSW: CMSSW_11_3_X_2020-12-13-0000/slc7_amd64_gcc900

#Python3

I found errors:

*** Error compiling 'src/PhysicsTools/NanoAOD/python/nanogen_cff.py'...

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-32463/20369

• This PR adds an extra 96KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Configuration/PyReleaseValidation/python/relval_steps.py modified in PR(s): Squash all Patatrack developments on top of CMSSW_11_3_0_pre5 #27983, Patatrack integration - Pixel workflows (12/N) #31854
  • File PhysicsTools/NanoAOD/python/muons_cff.py modified in PR(s): NanoAOD: pass through for muon and Isotrack above 15 GeV in pt, regardless of ID or dxy/dz #32103
  • File PhysicsTools/NanoAOD/python/nano_cff.py modified in PR(s): PPS nanoAOD #31531, Refactoring gen weight storage in EDM + Nano integration #32167
  • File PhysicsTools/NanoAOD/python/nanogen_cff.py modified in PR(s): Refactoring gen weight storage in EDM + Nano integration #32167

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-341cb0/11786/summary.html
CMSSW: CMSSW_11_3_X_2020-12-17-2300/slc7_amd64_gcc900

DAS Queries failed

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-341cb0/1325.81_TTbar_13_106Xv1NanoAODINPUT+TTbar_13_106Xv1NanoAODINPUT+NANOEDMMC2017_106XMiniAODv1+HARVESTNANOAODMC2017_106XMiniAODv1
• /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-341cb0/136.8523_RunJetHT2018C_nanoULremini+RunJetHT2018C_nanoULremini+NANOEDM2018_106Xv2+HARVESTNANOAOD2018_106Xv2

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 2716967
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2716938
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 34 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 151 log files, 36 edm output root files, 35 DQM output files

[mariadalfonso]

+xpog

[mariadalfonso]

For the record:

I wanted to add the wf for MC but
runTheMatrix make this query and doesn't work
dasgoclient --limit 0 --query 'file dataset=/RelValTTbar_13/CMSSW_10_6_20-106X_mc2017_realistic_v9-v1/MINIAODSIM site=T2_CH_CERN'

while only this that explicitly request rucio works
dasgoclient --limit 0 --query 'file dataset=/RelValTTbar_13/CMSSW_10_6_20-106X_mc2017_realistic_v9-v1/MINIAODSIM site=T2_CH_CERN system=rucio'

[kpedro88]

+upgrade

[santocch]

+1

[chayanit]

+1

[qliphy]

+operations

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1