Add DQM/TrackerRemapper package #33280

mmusich · 2021-03-26T17:48:53Z

PR description:

The goal of this PR is to introduce a new package DQM/TrackerRemapper which is targeted to contain software meant to produce various visualizations of the Pixel and Strip Tracker, scattered previously in other places (mainly in CondCore/SiPixelPlugins), mainly to avoid awkward dependencies from CondCore.
The new package contains the following interfaces:

Phase1PixelMaps: meant for separate Phase-1 Pixel Barrel and Forward Maps;
Phase1PixelROCMaps: meant for Phase-1 Pixel maps at the ROC-level;
Phase1PixelSummaryMap: meant for Summary Phase-1 Pixel maps;
SiStripTkMaps.h: meant for Strip Tracker Maps

These classes are depend on TH2Poly objects built using the raw data available at https://github.com/cms-data/DQM-SiStripMonitorClient/tree/master/Geometry.
The new classes are then used in various places (mainly in the Pixel and Strip Payload Inspector packages), but also in some analyzers in Alignment/OfflineValidation.

In addition it contains two analyzers that are meant for re-mapping studies of existing DQM histograms:

SiPixelPhase1Analyzer
TrackerRemapper

These are useful to produce more easily readable histograms from the DQM histograms available on the GUI.
We foresee this package to evolve to include also visualization aids for the Phase-2 Trackers.

PR validation:

This branch passes unit tests, as well as private tests.
An example plot obtainable with the following command is:

getPayloadData.py \
    --plugin pluginSiPixelLorentzAngle_PayloadInspector \
    --plot plot_SiPixelLorentzAngleFullPixelMap \
    --tag SiPixelLorentzAngle_v11_offline \
    --time_type Run \
    --iovs '{"start_iov": "324245", "end_iov": "324245"}' \
    --db Prod \
    --test ;

if this PR is a backport please specify the original PR and why you need to backport that PR:

Not a backport, no backport is needed.

cmsbuild · 2021-03-26T17:55:36Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33280/21786

This PR adds an extra 236KB to repository
Found files with invalid states:
- DQM/SiPixelPhase1Analyzer/interface/mat4.h:
  - Added: c9c907a
  - Modified: 557310e
  - Deleted: e519f0b
- DQM/SiPixelPhase1Analyzer/python/ConfFile_cfg.py:
  - Added: c9c907a
  - Modified: 0a15676
  - Deleted: e519f0b
- DQM/TrackerRemapper/python/ConfFile_cfg.py:
  - Added: 2666f38
  - Deleted: 33842d9
- DQM/SiPixelPhase1Analyzer/README.md:
  - Added: 406d1e5
  - Modified: 0a15676
  - Deleted: e519f0b
- DQM/SiPixelPhase1Analyzer/python/CfiFile_cfi.py:
  - Added: c9c907a
  - Deleted: e519f0b
- DQM/SiPixelPhase1Analyzer/plugins/SiPixelPhase1Analyzer.cc:
  - Added: c9c907a
  - Modified: 0a15676, 557310e
  - Deleted: e519f0b
- DQM/TrackerRemapper/test/ConfFile_cfg.py:
  - Added: 33842d9
  - Modified: b3d52cb
  - Deleted: a2098ca
- DQM/SiPixelPhase1Analyzer/plugins/BuildFile.xml:
  - Added: c9c907a
  - Deleted: e519f0b
- DQM/TrackerRemapper/python/CfiFile_cfi.py:
  - Added: 2666f38
  - Deleted: 33842d9
- DQM/SiPixelPhase1Analyzer/interface/SiPixelPhase1Analyzer.h:
  - Added: c9c907a
  - Modified: 557310e
  - Deleted: e519f0b
- DQM/TrackerRemapper/interface/TrackerRemapper.h:
  - Added: 2666f38
  - Modified: 70cb463
  - Deleted: fea156f

cmsbuild · 2021-03-26T17:56:02Z

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

Alignment/OfflineValidation
CondCore/SiPixelPlugins
CondCore/SiStripPlugins
DQM/TrackerRemapper

The following packages do not have a category, yet:

DQM/TrackerRemapper
Please create a PR for https://github.com/cms-sw/cms-bot/blob/master/categories_map.py to assign category

@malbouis, @yuanchao, @christopheralanwest, @cmsbuild, @tlampen, @ggovi, @pohsun, @francescobrivio can you please review it and eventually sign? Thanks.
@hdelanno, @adewit, @makortel, @tlampen, @tocheng, @VinInn, @OzAmram, @dkotlins, @fioriNTU, @jandrea, @ferencek, @idebruyn, @mmusich, @threus, @tvami this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

mmusich · 2021-03-26T17:57:41Z

@cmsbuild, please test

smuzaffar · 2021-03-26T17:59:41Z

assign dqm

cmsbuild · 2021-03-26T18:00:06Z

New categories assigned: dqm

@jfernan2,@andrius-k,@ahmad3213,@kmaeshima,@rvenditti,@ErnestaP you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild · 2021-03-26T20:34:04Z

-1

Failed Tests: HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1586a/13801/summary.html
COMMIT: 92c07fe
CMSSW: CMSSW_11_3_X_2021-03-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33280/13801/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2639935
DQMHistoTests: Total failures: 12
DQMHistoTests: Total nulls: 1
DQMHistoTests: Total successes: 2639900
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.004 KiB( 36 files compared)
DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

cmsbuild · 2021-03-29T09:07:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33280/21803

This PR adds an extra 248KB to repository
Found files with invalid states:
- DQM/SiPixelPhase1Analyzer/interface/mat4.h:
  - Added: c9c907a
  - Modified: 557310e
  - Deleted: e519f0b
- DQM/SiPixelPhase1Analyzer/python/ConfFile_cfg.py:
  - Added: c9c907a
  - Modified: 0a15676
  - Deleted: e519f0b
- DQM/TrackerRemapper/python/ConfFile_cfg.py:
  - Added: 2666f38
  - Deleted: 33842d9
- DQM/SiPixelPhase1Analyzer/README.md:
  - Added: 406d1e5
  - Modified: 0a15676
  - Deleted: e519f0b
- DQM/SiPixelPhase1Analyzer/python/CfiFile_cfi.py:
  - Added: c9c907a
  - Deleted: e519f0b
- DQM/SiPixelPhase1Analyzer/plugins/SiPixelPhase1Analyzer.cc:
  - Added: c9c907a
  - Modified: 0a15676, 557310e
  - Deleted: e519f0b
- DQM/TrackerRemapper/test/ConfFile_cfg.py:
  - Added: 33842d9
  - Modified: b3d52cb
  - Deleted: a2098ca
- DQM/SiPixelPhase1Analyzer/plugins/BuildFile.xml:
  - Added: c9c907a
  - Deleted: e519f0b
- DQM/TrackerRemapper/python/CfiFile_cfi.py:
  - Added: 2666f38
  - Deleted: 33842d9
- DQM/SiPixelPhase1Analyzer/interface/SiPixelPhase1Analyzer.h:
  - Added: c9c907a
  - Modified: 557310e
  - Deleted: e519f0b
- DQM/TrackerRemapper/interface/TrackerRemapper.h:
  - Added: 2666f38
  - Modified: 70cb463
  - Deleted: fea156f
There are other open Pull requests which might conflict with changes you have proposed:
- File CondCore/SiPixelPlugins/plugins/BuildFile.xml modified in PR(s): Clean BuildFiles and add source_only flags to fix warnings #33282

cmsbuild · 2021-04-06T12:07:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33280/21907

This PR adds an extra 296KB to repository
Found files with invalid states:
- DQM/SiPixelPhase1Analyzer/interface/mat4.h:
  - Added: c1ca088
  - Modified: ec503ce
  - Deleted: a6eb0fc
- DQM/SiPixelPhase1Analyzer/python/ConfFile_cfg.py:
  - Added: c1ca088
  - Modified: 124ae74
  - Deleted: a6eb0fc
- DQM/TrackerRemapper/python/ConfFile_cfg.py:
  - Added: cf03a7f
  - Deleted: 4339b33
- DQM/SiPixelPhase1Analyzer/README.md:
  - Added: 3d966a1
  - Modified: 124ae74
  - Deleted: a6eb0fc
- DQM/SiPixelPhase1Analyzer/python/CfiFile_cfi.py:
  - Added: c1ca088
  - Deleted: a6eb0fc
- DQM/SiPixelPhase1Analyzer/plugins/SiPixelPhase1Analyzer.cc:
  - Added: c1ca088
  - Modified: 124ae74, ec503ce
  - Deleted: a6eb0fc
- DQM/TrackerRemapper/test/ConfFile_cfg.py:
  - Added: 4339b33
  - Modified: d89aa4f
  - Deleted: a54ba41
- DQM/SiPixelPhase1Analyzer/plugins/BuildFile.xml:
  - Added: c1ca088
  - Deleted: a6eb0fc
- DQM/TrackerRemapper/python/CfiFile_cfi.py:
  - Added: cf03a7f
  - Deleted: 4339b33
- DQM/SiPixelPhase1Analyzer/interface/SiPixelPhase1Analyzer.h:
  - Added: c1ca088
  - Modified: ec503ce
  - Deleted: a6eb0fc
- DQM/TrackerRemapper/interface/TrackerRemapper.h:
  - Added: cf03a7f
  - Modified: 29324ae
  - Deleted: 4622a27

cmsbuild · 2021-04-06T12:07:38Z

Pull request #33280 was updated. @malbouis, @andrius-k, @yuanchao, @kmaeshima, @christopheralanwest, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @tlampen, @ggovi, @pohsun, @rvenditti, @francescobrivio can you please check and sign again.

mmusich · 2021-04-06T12:15:18Z

Sorry for the iterations. The last round of commits addresses violation of cmssw coding rule 4.3:

Header ﬁles must not contain any implementation except for class templates and code to be inlined.

now it should be in the final version.

mmusich · 2021-04-06T12:15:30Z

@cmsbuild, please test

cmsbuild · 2021-04-06T15:03:21Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d1586a/14015/summary.html
COMMIT: 18d8f14
CMSSW: CMSSW_11_3_X_2021-04-05-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/33280/14015/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 37
DQMHistoTests: Total histograms compared: 2640868
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2640845
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
Checked 155 log files, 37 edm output root files, 37 DQM output files
TriggerResults: no differences found

jfernan2 · 2021-04-06T19:21:19Z

+1

ggovi · 2021-04-07T07:36:59Z

+1

mmusich · 2021-04-07T07:44:18Z

@malbouis, @yuanchao, @christopheralanwest, @tlampen, @francescobrivio
please review at earliest convenience, the changes in the AlCa package (Alignment/OfflineValidation) are somewhat trivial:

re-ordering of includes in a build file
changes reflecting the change of naming of a public method from upper to lower case to follow coding rules 1 and 2

Thank you

christopheralanwest · 2021-04-07T22:55:59Z

+alca

Changes within AlCa domain are mainly technical

cmsbuild · 2021-04-07T22:56:48Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2021-04-08T06:51:52Z

+1

cmsbuild added this to the CMSSW_11_3_X milestone Mar 26, 2021

cmsbuild added alca-pending code-checks-pending db-pending new-package-pending orp-pending pending-signatures tests-pending labels Mar 26, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 26, 2021

mmusich mentioned this pull request Mar 26, 2021

add DQM/TrackerRemapper to dqm signature area cms-sw/cms-bot#1523

Merged

cmsbuild added tests-started and removed tests-pending labels Mar 26, 2021

cmsbuild added the dqm-pending label Mar 26, 2021

cmsbuild added tests-rejected and removed tests-started labels Mar 26, 2021

cmsbuild mentioned this pull request Mar 27, 2021

Clean BuildFiles and add source_only flags to fix warnings #33282

Merged

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-rejected labels Mar 29, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 29, 2021

cmsbuild added the code-checks-pending label Apr 6, 2021

cmsbuild added code-checks-approved and removed code-checks-pending labels Apr 6, 2021

cmsbuild added tests-started and removed tests-pending labels Apr 6, 2021

cmsbuild added tests-approved and removed tests-started labels Apr 6, 2021

cmsbuild added dqm-approved and removed dqm-pending labels Apr 6, 2021

cmsbuild added db-approved and removed db-pending labels Apr 7, 2021

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Apr 7, 2021

cmsbuild mentioned this pull request Apr 7, 2021

[RFC] Test clang-tidy --checks misc-definitions-in-headers #33366

Closed

cmsbuild added orp-approved and removed orp-pending labels Apr 8, 2021

cmsbuild merged commit a851ab9 into cms-sw:master Apr 8, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add DQM/TrackerRemapper package #33280

Add DQM/TrackerRemapper package #33280

mmusich commented Mar 26, 2021 •

edited

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

mmusich commented Mar 26, 2021

smuzaffar commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 29, 2021

cmsbuild commented Apr 6, 2021

cmsbuild commented Apr 6, 2021

mmusich commented Apr 6, 2021

mmusich commented Apr 6, 2021

cmsbuild commented Apr 6, 2021

jfernan2 commented Apr 6, 2021

ggovi commented Apr 7, 2021

mmusich commented Apr 7, 2021

christopheralanwest commented Apr 7, 2021

cmsbuild commented Apr 7, 2021

silviodonato commented Apr 8, 2021

Add DQM/TrackerRemapper package #33280

Add DQM/TrackerRemapper package #33280

Conversation

mmusich commented Mar 26, 2021 • edited

PR description:

PR validation:

if this PR is a backport please specify the original PR and why you need to backport that PR:

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

mmusich commented Mar 26, 2021

smuzaffar commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

cmsbuild commented Mar 26, 2021

Comparison Summary

cmsbuild commented Mar 29, 2021

cmsbuild commented Apr 6, 2021

cmsbuild commented Apr 6, 2021

mmusich commented Apr 6, 2021

mmusich commented Apr 6, 2021

cmsbuild commented Apr 6, 2021

Comparison Summary

jfernan2 commented Apr 6, 2021

ggovi commented Apr 7, 2021

mmusich commented Apr 7, 2021

christopheralanwest commented Apr 7, 2021

cmsbuild commented Apr 7, 2021

silviodonato commented Apr 8, 2021

mmusich commented Mar 26, 2021 •

edited