HcalDQM - Correct LED Calibration Channels List

[lwang046]

PR description:

Correct the list of LED calibration channels via emap accessing instead of hardcoded list, and fix the histogram y-axis ceiling issue for some plots by using TH1D.

PR validation:

Passed runTheMatrix.py -l limited -i all --ibeos test

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33827/22844

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33827/22844/code-format.patch
  e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33827/22844/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33827/22845

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @lwang046 for master.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please review it and eventually sign? Thanks.
@abdoulline, @DryRun this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-330150/15290/summary.html
COMMIT: 6cc4097
CMSSW: CMSSW_12_0_X_2021-05-24-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33827/15290/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2650461
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 10697.586 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 385.352 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 1000.0,... ): 10.273 KiB Hcal/RecHitTask
• DQMHistoSizes: changed ( 1000.0,... ): 2.031 KiB Hcal/TPTask
• DQMHistoSizes: changed ( 1000.0,... ): 0.012 KiB Hcal/RunInfo
• DQMHistoSizes: changed ( 10024.0,... ): 385.441 KiB Hcal/DigiTask
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[jfernan2]

@lwang046 HF plot on Hcal / DigiTask / LED_ADCvsBX / Subdet now does not get filled, is this expected?

https://tinyurl.com/yj9hhhuf
https://tinyurl.com/yhf6b9r7

[lwang046]

Hi @jfernan2 yes that's expected. Previously the code was filling that plot from gibberish channels, now it should only fill LED calibration channels.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-33827/22872

• This PR adds an extra 36KB to repository

[cmsbuild]

Pull request #33827 was updated. @andrius-k, @kmaeshima, @ErnestaP, @ahmad3213, @cmsbuild, @jfernan2, @rvenditti can you please check and sign again.

[jfernan2]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-330150/15339/summary.html
COMMIT: ba7dc4b
CMSSW: CMSSW_12_0_X_2021-05-26-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/33827/15339/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1264 differences found in the comparisons
• DQMHistoTests: Total files compared: 37
• DQMHistoTests: Total histograms compared: 2650486
• DQMHistoTests: Total failures: 3677
• DQMHistoTests: Total nulls: 19
• DQMHistoTests: Total successes: 2646768
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 10743.994 KiB( 36 files compared)
• DQMHistoSizes: changed ( 1000.0,... ): 385.363 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 1000.0,... ): 10.285 KiB Hcal/RecHitTask
• DQMHistoSizes: changed ( 1000.0,... ): 2.043 KiB Hcal/TPTask
• DQMHistoSizes: changed ( 1000.0,... ): 0.012 KiB Hcal/RunInfo
• DQMHistoSizes: changed ( 10024.0,... ): 385.453 KiB Hcal/DigiTask
• DQMHistoSizes: changed ( 140.53 ): 44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): 1.172 KiB RPC/DCSInfo
• Checked 155 log files, 37 edm output root files, 37 DQM output files
• TriggerResults: no differences found

[abdoulline]

All reco differences come from aforementioned 140.53 due to input files difference...

[jfernan2]

+1
Backport tested succesfully in Online DQM at P5 playback

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1