[Backport] Track-gen matching passing through TrackingParticle #33996
Conversation
…d on their association to a gen particle
…ation is missing in AOD
…ection is missing in the associator
|
@cmsbuild, please test |
|
backport of #33774 |
| @@ -75,6 +76,10 @@ | |||
| (pp_on_AA_2018 | _mAOD).toReplaceWith(slimmingTask, | |||
| slimmingTask.copyAndExclude([slimmedLowPtElectronsTask])) | |||
|
|
|||
| from Configuration.Eras.Modifier_bParking_cff import bParking | |||
| _bParking_slimmingTask = cms.Task(slimmingTask.copy(),packedCandidateToGenAssociationTask) | |||
| bParking.roReplaceWith(slimmingTask,_bParking_slimmingTask) | |||
There was a problem hiding this comment.
| bParking.roReplaceWith(slimmingTask,_bParking_slimmingTask) | |
| bParking.toReplaceWith(slimmingTask,_bParking_slimmingTask) |
|
@elusian , does this branch the same as for 12_0_X? |
|
It's a backport. The additional changes should be only code format (not needed on master) and the activation using the bParking modifier |
|
@cms-sw/simulation-l2 @cms-sw/pdmv-l2 @cms-sw/upgrade-l2 Do you have further comments? |
|
+1 |
|
+Upgrade |
|
+operations |
|
+1 |
cmsbuild
added
fully-signed
pdmv-approved
and removed
pdmv-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_12_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
|
@elusian @slava77 Sorry to come back to this. In 10_6_X IB, there is a reval error after merging this PR, can you have a look and comment? Is it expected similarly as mentioned in above, e.g. ----- Begin Fatal Exception 28-Aug-2021 03:33:10 CEST----------------------- Additional Info: |
|
Hello I think this can be solved by adding 'Digi' to the steps for the ParkingBPH upgradeSteps, here https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_X/Configuration/PyReleaseValidation/python/upgradeWorkflowComponents.py#L225 and modify the line here https://github.com/cms-sw/cmssw/blob/CMSSW_10_6_X/Configuration/PyReleaseValidation/python/relval_steps.py#L3300 to create the DigiFull_ParkingBPH_2018 step. However, I'm not very familiar with that code so I would ask for a double check to avoid breaking something unrelated. |
|
It seems that the fix works for this particular workflow, let me know if you agree with the changes or if I need to test anything else |
Thank you @elusian |
|
In master the PR is not gated behind a modifier, so it's enabled by default. |
I am not 100% sure I understand the full logic. However, if master does not need a fix, I would only implement the fix where needed. The code in upgradeWorkflowComponents.py diverged significantly from 10_6 to the current one in the master, and it makes sense that corrections can be applied independently. |
PR description:
This PR adds a way to match generalTracks (in AOD) and packedPFCandidates and lostTracks (in miniAOD) to a subset of genParticles, using association by hit on TrackingParticles.
The association is performed on step3 and just replicated in the miniAOD.
Since the track association by hit needs both TrackingParticles and SimLink for pixel and strips and the SimLink collections are not available in RAWSIM, two plugins are created to be run in step2 to add two pruned collections and avoid adding the all the SimLink, which have a non negligible size.
The changes contained are:
No plugin is needed for association between tracks and GenParticles through TrackingParticle as it is already present in CMSSW (MCTrackMatcher).
PR validation:
On a B+->Psi2SK sample (one of the possible targets for this PR) we registered this increases in size, timing and memory
if this PR is a backport please specify the original PR and why you need to backport that PR:
Backport of #33774 needed for BParking reprocessing