initialize all of pat Muon sim info

[slava77]

random differences in event size were observed on one of miniAOD tests in slimmedMuons.
I tracked these down to simTpEvent_ and simMatchQuality_, which were indeed not initialized in the code.
This PR completes the initSimInfo() method to initialize these data members as well.

I used 0 for default values, since this will match the default "non-initialization"

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34056/23194

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @slava77 (Slava Krutelyov) for master.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @cbernet, @gouskos, @rovere, @hatakeyamak this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-346498/15798/summary.html
COMMIT: 0ca5060
CMSSW: CMSSW_12_0_X_2021-06-08-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34056/15798/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• [HLT] Apply code-checks/format with misc-definitions-in-headers #34046 @smuzaffar: [HLT] Apply code-checks/format with misc-definitions-in-headers
• Removed CalibTracker/SiStripCommon dependency from CalibFormats/SiStripObjects #33888 @Dr15Jones: Removed CalibTracker/SiStripCommon dependency from CalibFormats/SiStripObjects
• Ecal DB payload comparison viewer #33930 @jeanfay: Ecal DB payload comparison viewer
• [HETEROGENEOUS] Apply code-checks/format with misc-definitions-in-headers #34045 @smuzaffar: [HETEROGENEOUS] Apply code-checks/format with misc-definitions-in-headers
• Remove direct boost and ROOT dependencies from CondFormats/GBRForest etc. #33890 @guitargeek: Remove direct boost and ROOT dependencies from CondFormats/GBRForest etc.
• Add argument postGenerationCommand to ExternalLHEProducer and provide mergeLHE.py script [new] #33985 @colizz: Add argument postGenerationCommand to ExternalLHEProducer and provide mergeLHE.py script [new]
• Reduced excessive number of iterations in test. #34029 @ericcano: Reduced excessive number of iterations in test.
• Removed unnecessary includes in CalibFormats/*Objects #33913 @Dr15Jones: Removed unnecessary includes in CalibFormats/*Objects

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-346498/15798/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-346498/15798/git-merge-result

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2862520
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 1
• DQMHistoTests: Total successes: 2862491
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
• DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[slava77]

+reconstruction

for #34056 0ca5060

• jenkins tests pass and comparisons with the baseline show no (relevant) differences

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1