Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex81 Modify the Phase2 scenarios to work for dd4hep #34284

Merged
merged 2 commits into from Jul 2, 2021

Conversation

bsunanda
Copy link
Contributor

PR description:

Modify the Phase2 scenarios (including the right cff for tracker) to work for dd4hep

PR validation:

Tested using runTheMatrix Phase2 workflows

if this PR is a backport please specify the original PR and why you need to backport that PR:

Nothing special

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34284/23593

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34284/23594

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda (Sunanda Banerjee) for master.

It involves the following packages:

Configuration/Geometry
Geometry/TrackerNumberingBuilder

@civanch, @Dr15Jones, @makortel, @cvuosalo, @ianna, @kpedro88, @cmsbuild, @srimanob, @mdhildreth can you please review it and eventually sign? Thanks.
@vargasa, @makortel, @JanFSchulte, @VinInn, @Martin-Grunewald, @mtosi, @fabiocos, @slomeo, @venturia this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8cf757/16331/summary.html
COMMIT: 49f1f6c
CMSSW: CMSSW_12_0_X_2021-06-29-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34284/16331/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785711
  • DQMHistoTests: Total failures: 18
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785670
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

srimanob commented Jul 1, 2021

Hi @bsunanda
As PR test does not include Phast-2 dd4hep workflow, could you please clarify a bit on testing and it is only a known stopper to run dd4hep in Phase-2 until the end (not include validation) ?

@cvuosalo
Copy link
Contributor

cvuosalo commented Jul 1, 2021

+1

@srimanob
Copy link
Contributor

srimanob commented Jul 2, 2021

+Upgrade

As presented in the simulation meeting (2 July), https://indico.cern.ch/event/1053571/

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 2, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 2, 2021

+1

@cmsbuild cmsbuild merged commit 3a2a90d into cms-sw:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants