Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BeamSpotOnline tags for CRUZET #34348

Merged
merged 3 commits into from Jul 7, 2021

Conversation

francescobrivio
Copy link
Contributor

PR description:

This PR is the forward port of #34333 to update the GTs for CRUZET 2021:

  • udpated names of the tags in the DQM online clients that write the payloads
  • removed the ESSource in the onlinebeammonitor DQM client (avaid crash from multiple sources)
  • update HLT and Express GTs which contain the new tags:

See #34333 for more details.

The GT diffs are:
Run 3 data HLT
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_HLT_v2/113X_dataRun3_HLT_v3

Run 3 data (express)
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/113X_dataRun3_Express_v3/113X_dataRun3_Express_v4

PR validation:

Tested with:

runTheMatrix.py -l 138.2 --ibeos -j 8
addOnTests.py -j 8

Back/Forward-port

This is the forward port of #34333 to master.

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 138.2

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34348/23720

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

A new Pull Request was created by @francescobrivio for master.

It involves the following packages:

Configuration/AlCa
DQM/Integration

@malbouis, @andrius-k, @yuanchao, @kmaeshima, @ErnestaP, @ahmad3213, @rvenditti, @jfernan2, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@batinkov, @battibass, @makortel, @tocheng, @Martin-Grunewald, @mmusich, @threus, @fabiocos this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

test parameters:

  • workflow = 138.2

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

please test

@francescobrivio
Copy link
Contributor Author

please test

@qliphy is it normal that comparison and required tests are still "Pending"?

@qliphy
Copy link
Contributor

qliphy commented Jul 6, 2021

@qliphy is it normal that comparison and required tests are still "Pending"?

Sometimes it happened. @smuzaffar
Let's wait a bit more. Otherwise we can abort and make test again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 6, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b88022/16491/summary.html
COMMIT: 3dee919
CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34348/16491/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-b88022/138.2_RunCosmics2020+RunCosmics2020+RECOCOSDEXPRUN3+ALCACOSDEXPRUN3+HARVESTDCEXPRUN3

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2785901
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

urgent

@cmsbuild cmsbuild added the urgent label Jul 7, 2021
@francescobrivio
Copy link
Contributor Author

+alca

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

@cms-sw/dqm-l2 Do you have any comments?

@jfernan2
Copy link
Contributor

jfernan2 commented Jul 7, 2021

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants