Prefetch for EDLoopers

[Dr15Jones]

PR description:

Do asynchronous prefetching for EDLoopers. This is needed to support the ESGetToken usage.

PR validation:

The framework unit tests run and the unit test failing in the IB where the auto-generated test file

tmp/PixelBaryCentreTool/alignment_forGeomComp_auto:run2_data_TrackerAlignment_2009_v1_express_r272011_1.py

was failing now works.

fixes #34223

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34369/23745

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer
Alignment/MillePedeAlignmentAlgorithm
FWCore/Framework
FWCore/Integration

@smuzaffar, @Dr15Jones, @malbouis, @makortel, @cmsbuild, @yuanchao, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @adewit, @makortel, @wddgit, @tocheng, @tlampen, @mmusich this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test

[cmsbuild]

-1

Failed Tests: ClangBuild
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae402d/16509/summary.html
COMMIT: 6e0de14
CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34369/16509/install.sh to create a dev area with all the needed externals and cmssw changes.

Clang Build

I found compilation warning while trying to compile with clang. Command used:

USER_CUDA_FLAGS='--expt-relaxed-constexpr' USER_CXXFLAGS='-Wno-register -fsyntax-only' scram build -k -j 32 COMPILER='llvm compile'

See details on the summary page.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34369/23746

• This PR adds an extra 88KB to repository

• There are other open Pull requests which might conflict with changes you have proposed:

  • File Alignment/CommonAlignmentProducer/src/AlignmentProducerBase.cc modified in PR(s): Run 2, Run3, and Phase2 tracker: adding T27 (geometry with bricked pixels) and support for storing bricked pixel information #34120
  • File FWCore/Framework/src/EventProcessor.cc modified in PR(s): Implement persistence for ProcessBlock products #33969
  • File FWCore/Integration/test/BuildFile.xml modified in PR(s): Implement persistence for ProcessBlock products #33969

[cmsbuild]

Pull request #34369 was updated. @smuzaffar, @Dr15Jones, @malbouis, @makortel, @cmsbuild, @yuanchao, @tlampen, @pohsun, @francescobrivio, @tvami can you please check and sign again.

[tvami]

@cmsbuild, please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae402d/16510/summary.html
COMMIT: e215194
CMSSW: CMSSW_12_0_X_2021-07-06-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34369/16510/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS StaticAnalyzer warnings: There are 3 EventSetupRecord::get warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ae402d/16510/llvm-analysis/esrget-sa.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785924
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785901
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[makortel]

+1

[Dr15Jones]

@cms-sw/alca-l2 please review so we can fix the failing unit tests in the IB.

[tvami]

+alca

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1