Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate module configuration in RecoEgamma{EgammaIsolationAlgos} to use default cfipython #34371

Merged
merged 2 commits into from Jul 7, 2021

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Jul 7, 2021

PR description:

Optimization of the python configurations: Improve maintainability by cleaning up the duplicated and cloning from the default/reference configurations. (The previous PRs : PR#33207, PR#33307, PR#33352, PR#33543, PR#33563, PR#33671, PR#34007, PR#34091, PR#34009, PR#34155)

In this PR, 5 files changed.
modified: RecoEgamma/EgammaIsolationAlgos/python/egmElectronIsolationPUPPI_cff.py
modified: RecoEgamma/EgammaIsolationAlgos/python/egmPhotonIsolationAOD_cff.py
modified: RecoEgamma/EgammaIsolationAlgos/python/egmPhotonIsolationMiniAOD_cff.py
modified: RecoEgamma/EgammaIsolationAlgos/python/egmPhotonIsolationPUPPI_cff.py
modified: RecoEgamma/EgammaIsolationAlgos/python/pfClusterIsolation_cfi.py

commit 1 : Replace explicit configuration with a reference from cfipython/. (migrating EDProducer("type", .. -> typeDefaylt.clone() ) and Remove the type specifications already presented in cfipython/fillDescriptions reference for improved syntax safety.
commit 2 : Remove the duplicated parameters that are exactly the same value in cfipython reference.

PR validation:

Event Content comparison check was also done and there is no change with these updates.
Tested in CMSSW_12_0_X, the basic test all passed in the CMSSW PR instructions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34371/23751

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

RecoEgamma/EgammaIsolationAlgos

@perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@Sam-Harper, @jainshilpi, @lgray, @sobhatta, @afiqaize, @varuns23, @ram1123 this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2021

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4a00c5/16523/summary.html
COMMIT: c008005
CMSSW: CMSSW_12_0_X_2021-07-06-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34371/16523/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 38
  • DQMHistoTests: Total histograms compared: 2785924
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2785895
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.004 KiB( 37 files compared)
  • DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
  • Checked 160 log files, 37 edm output root files, 38 DQM output files
  • TriggerResults: no differences found

@perrotta
Copy link
Contributor

perrotta commented Jul 7, 2021

+reconstruction

  • Technical. migrated according to what declared in the PR description
  • Jenkins tests pass

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2021

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@qliphy
Copy link
Contributor

qliphy commented Jul 7, 2021

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants