Fix issues #34648

[hyunyong]

PR description:

fixes #34648

PR validation:

Using template /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/alignment_forGeomComp_cfg_TEMPLATE.py
and plotting macros from /cvmfs/cms-ib.cern.ch/week1/slc7_amd64_gcc900/cms/cmssw-patch/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/MillePedeAlignmentAlgorithm/macros/
Running in /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/

============================================================
 Run 272011: auto:run2_data / TrackerAlignment_2009_v1_express (=1) vs auto:run2_data / SiPixelAli_PCL_v0_prompt (=2)
============================================================
Removing old file treeFile_auto_run2_data_TrackerAlignment_2009_v1_express_r272011_1.root
Removing old file treeFile_auto_run2_data_SiPixelAli_PCL_v0_prompt_r272011_2.root

Processing allMillePede.C...
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./GFUtils/GFHistManager_C.so
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./MillePedeTrees_C.so
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./PlotMillePede_C.so
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./PlotMillePedeIOV_C.so
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./CompareMillePede_C.so
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./PlotMilleMonitor_C.so
Processing pixelPositionChange.C+("/afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/treeFile_auto_run2_data_TrackerAlignment_2009_v1_express_r272011_1.root", "/afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/treeFile_auto_run2_data_SiPixelAli_PCL_v0_prompt_r272011_2.root")...
Info in <TUnixSystem::ACLiC>: creating shared library /afs/cern.ch/work/h/hyunyong/CMSSW_12_0_X_2021-07-26-1100/src/Alignment/TrackerAlignment/test/PixelBaryCentrePlottingTools/./pixelPositionChange_C.so
Info in <TCanvas::Print>: pdf file canvas0_0.pdf has been created
Info in <TCanvas::Print>: pdf file canvas0_1.pdf has been created
Info in <TCanvas::Print>: pdf file canvas0_2.pdf has been created
Info in <TCanvas::Print>: pdf file canvas0_3.pdf has been created
Info in <TCanvas::Print>: pdf file canvas0_4.pdf has been created
Info in <TCanvas::Print>: pdf file canvas1_0.pdf has been created
Info in <TCanvas::Print>: pdf file canvas1_1.pdf has been created
Info in <TCanvas::Print>: pdf file canvas1_2.pdf has been created
Info in <TCanvas::Print>: pdf file canvas1_3.pdf has been created
Info in <TCanvas::Print>: pdf file canvas1_4.pdf has been created
====================================================
BPIX:
====================================================
x1 x2: -0.0262721 -0.0262721
y1 y2: -0.0759665 -0.0759665
z1 z2: -0.498492 -0.498492
Delta(x,y,z) = 2-1 = (0,0,0) mum
====================================================
Pixel:
====================================================
x1 x2: -0.0400418 -0.0400418
y1 y2 -0.200817 -0.200817
z1 z2: -0.55104 -0.55104
Delta(x,y,z) = 2-1 = (0,0,0) mum
|  | *treeFile_auto_run2_data_TrackerAlignment_2009_v1_express_r272011_1.root* || *treeFile_auto_run2_data_TrackerAlignment_2009_v1_express_r272011_1.root*||
| *Position* |  *BPIX* | *Full Pixel* | *BPIX* | *Full Pixel* |
|  x  | -0.0262721 | -0.0400418 | -0.0262721 | -0.0400418 |
|  y  | -0.0759665 | -0.200817 | -0.0759665 | -0.200817 |
|  z  | -0.498492 | -0.55104 | -0.498492 | -0.55104 |

====================================================
====================================================
====================================================

[tvami]

type bugfix

[tvami]

fixes #34648

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34654/24259

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @hyunyong for master.

It involves the following packages:

• Alignment/CommonAlignmentProducer (alca)

@malbouis, @yuanchao, @cmsbuild, @tlampen, @pohsun, @francescobrivio, @tvami can you please review it and eventually sign? Thanks.
@pakhotin, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[francescobrivio]

urgent

[francescobrivio]

please test

[mmusich]

please abort

[mmusich]

test parameters:

• addpkg = Alignment/TrackerAlignment

[mmusich]

@cmsbuild please test

Now it will actually test the failing tests

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac83ba/17265/summary.html
COMMIT: cc984f8
CMSSW: CMSSW_12_0_X_2021-07-27-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34654/17265/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

The workflows 140.53 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons

Summary:

• No significant changes to the logs found
• Reco comparison results: 1306 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2998564
• DQMHistoTests: Total failures: 3683
• DQMHistoTests: Total nulls: 20
• DQMHistoTests: Total successes: 2994839
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -45.699 KiB( 38 files compared)
• DQMHistoSizes: changed ( 140.53 ): -44.531 KiB Hcal/DigiRunHarvesting
• DQMHistoSizes: changed ( 140.53 ): -1.172 KiB RPC/DCSInfo
• DQMHistoSizes: changed ( 312.0 ): 0.004 KiB MessageLogger/Warnings
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[tvami]

+alca

• the unit test reported in Unit failure: test_PixelBaryCentreTool had ERRORS #34648 is now successful, see:
  https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ac83ba/17265/unitTests/src/Alignment/TrackerAlignment/test/test_PixelBaryCentreTool/testing.log
• the comparison failures are due to different input files in the step 1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy, @perrotta (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1