[HGCAL] From CaloParticle to SimTrackster in the Validation linking section

[lecriste]

PR description:

This PR replaces the CaloParticle collection with a dedicated SimTrackster collection, in the HGCAL Validation section of the Tracksters linking to Sim objects.
No changes are expected in the output, except for some unchanged histograms moved to a new DQM subfolder.

PR validation:

runTheMatrix -l limited

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34800/24517

• This PR adds an extra 76KB to repository

[cmsbuild]

A new Pull Request was created by @lecriste (Leonardo Cristella) for master.

It involves the following packages:

• RecoHGCal/Configuration (upgrade, reconstruction)
• RecoHGCal/TICL (upgrade, reconstruction)
• Validation/HGCalValidation (dqm)

@perrotta, @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @bsunanda, @felicepantaleo, @rovere, @lgray, @cseez, @apsallid, @sobhatta, @pfs, @hatakeyamak, @ebrondol, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy, @perrotta you are the release manager for this.

cms-bot commands are listed here

[slava77]

@cmsbuild please test

[cmsbuild]

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b5b4e/17578/summary.html
COMMIT: 559fc3d
CMSSW: CMSSW_12_1_X_2021-08-05-1100/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34800/17578/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

• 23234.0

----- Begin Fatal Exception 05-Aug-2021 20:32:42 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HGCalValidator label='hgcalValidator'
Exception Message:
StatusMismatch: Parameter 'label_LCToCPLinking' is designated as tracked in the code,
but is designated as untracked in the configuration file.
Please remove 'untracked' from the configuration file for parameter 'label_LCToCPLinking'.
----- End Fatal Exception -------------------------------------------------

• 34634.0

----- Begin Fatal Exception 05-Aug-2021 20:33:38 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HGCalValidator label='hgcalValidator'
Exception Message:
StatusMismatch: Parameter 'label_LCToCPLinking' is designated as tracked in the code,
but is designated as untracked in the configuration file.
Please remove 'untracked' from the configuration file for parameter 'label_LCToCPLinking'.
----- End Fatal Exception -------------------------------------------------

• 28234.0

----- Begin Fatal Exception 05-Aug-2021 20:36:13 CEST-----------------------
An exception of category 'Configuration' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=HGCalValidator label='hgcalValidator'
Exception Message:
StatusMismatch: Parameter 'label_LCToCPLinking' is designated as tracked in the code,
but is designated as untracked in the configuration file.
Please remove 'untracked' from the configuration file for parameter 'label_LCToCPLinking'.
----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

• 34834.999

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34800/24529

• This PR adds an extra 76KB to repository

[cmsbuild]

Pull request #34800 was updated. @perrotta, @andrius-k, @kmaeshima, @ErnestaP, @kpedro88, @cmsbuild, @AdrianoDee, @srimanob, @jfernan2, @ahmad3213, @slava77, @jpata, @rvenditti can you please check and sign again.

[slava77]

@cmsbuild please test

[slava77]

Those TTbar workflows are still failing in my local test though.

if you are referring to the RelVals-INPUT list in #34800 (comment); I think that these were appearing in other PR tests a couple of days ago but were gone since about a day.

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7b5b4e/17763/summary.html
COMMIT: 560dc61
CMSSW: CMSSW_12_1_X_2021-08-12-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/34800/17763/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• ROOTFileChecks: Some differences in event products or their sizes found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 39
• DQMHistoTests: Total histograms compared: 2986552
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2986529
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 12.656 KiB( 38 files compared)
• DQMHistoSizes: changed ( 23234.0,... ): 3.164 KiB HGCAL/HGCalValidator
• Checked 165 log files, 37 edm output root files, 39 DQM output files
• TriggerResults: no differences found

[jfernan2]

+1

[slava77]

+reconstruction

for #34800 560dc61

• code changes are in line with the PR description and the follow up review
• jenkins tests pass and comparisons with the baseline show no relevant differences in comparisons
  • apparently the relocation of the trackster creation to the new ticl::addTrackster method changed the random value in the iteration data member; this randomness is supposed to go away after initialize Trackster::iterationIndex_ #34858 is merged
  • ROOTFileChecks confirm that the new products from ticlSimTrackstersFromCP appear in the outputs, e.g. in the phase-2 wf 34834.999 in step3.root

[lecriste]

@srimanob, can you please review this PR?

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1

[perrotta]

@lecriste @slava77 do I understand correctly that the randomness discussed above is the responsible of the differences we see in the jenkins tests for ticlTracksters_ticlSimTracksters__RECO_obj_ticlIteration content, apparently since the merging of this PR? (See for example #34886 (comment))

Are those random differences expected to disappear after #34858 is merged?